Pass serverPath to init #11
Comments
|
Although you can technically use Rollup to create libraries (using the Instead your library should simply publish ES6 modules, and it would be the end user's responsibility to use Rollup (or Webpack, or...) Having said that, I would like to support this use case, but it is really tricky. So as a workaround you can simply use |
|
I've been using rollup to make bundles for libraries (https://www.github.com/vega/vega-lite) e.g. for browser use via a CDN. A use case is for example observablehq. I have innlined wasm so far in my library (https://github.com/domoritz/arrow-wasm) but it would be nice to give people the option to provide a server path and reduce code size. I'd love if the generated init function took an optional path. My hope is to generate different bundles that people can load and also provide es code for people who want to themselves bundle the library. |
Yes, that's the end goal, though as I said it is tricky to implement. |
|
Would #12 work? I tried it locally and now this works <html>
<head>
<meta content="text/html;charset=utf-8" http-equiv="Content-Type"/>
</head>
<body>
<script src="./dist/hello.js"></script>
<script>
async function run() {
// breaks
// const module = await hello();
// works
const module = await hello('./dist/');
// also works if we set the asset name
// const module = await hello('./dist/hello.wasm');
console.log(module.greet());
}
run();
</script>
</body>
</html>rollup.config.js import rust from "@wasm-tool/rollup-plugin-rust";
export default {
input: "index.js",
output: {
file: "dist/hello.js",
format: "umd",
name: "hello"
},
plugins: [
rust(),
],
};lib.rs use wasm_bindgen::prelude::*;
#[wasm_bindgen]
pub fn greet() -> String {
"Hello, World!".into()
} |
|
We could even do this code: `
import * as exports from ${import_path};
${prelude}
async function init(input) {
if (typeof input === 'string' && input.endsWith('/')) {
input += ${import_wasm};
}
await exports.default(input ?? ${import_wasm});
return exports;
}
export default Object.assign(init, exports);
`,and then one could await hello('./dist/');
console.log(hello.greet()); |
|
@Pauan what do you think? |
|
@domoritz Sorry for the delay. I don't think #12 will work, because there are three parts to the path:
Your solution only allows for prepending the application path (3). But there are also legitimate reasons for the application to want to replace the path completely, so I think we need to support that as well. |
|
Thanks for getting back to me. There is nothing to be sorry for. My approach actually does support overwriting the path entirely. Only when the provided string ends with |
|
Ahh, right, that's an interesting approach. Let me think about it. |
|
What do you think? I'm happy to make more changes if you see issues with the approach. |
|
After thinking about it, I don't like it, it seems too "magical". Instead, I think something like this would be better: init({
serverPath: (path) => "/foo/" + path
})This has two big benefits:
|
|
Thanks for your feedback. I do like the idea of taking a function instead of a string to modify the path, though. However, I don't think we should use normal function arguments instead of an object. I updated the code to support a function as you suggested. |
|
How do you feel about my proposed solution? |
I would like to publish a package to npm and therefore cannot predict the server path. I see that there is an
initfunction that takes the path to the wasm file. Is there a way to generate a bundle that exposes this init function directly?The text was updated successfully, but these errors were encountered: