-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(wash-lib)!: add support for inspecting wit #1161
Conversation
b8119a8
to
c86f7b9
Compare
c86f7b9
to
91878f1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple in-line questions, and one here: I see updated tests for the default case, but not a test case for the new functionality. Shouldn't we have a new test for that?
Signed-off-by: Brooks Townsend <brooksmtownsend@gmail.com> satisfy overlord Signed-off-by: Brooks Townsend <brooksmtownsend@gmail.com> edge case Signed-off-by: Brooks Townsend <brooksmtownsend@gmail.com> use wasmparser to parse inspect Signed-off-by: Brooks Townsend <brooksmtownsend@gmail.com> address PR comments Signed-off-by: Brooks Townsend <brooksmtownsend@gmail.com>
91878f1
to
78c18bc
Compare
Feature or Problem
This PR allows
wash
users to add--wit
after or before their file/oci reference to print out the embedded wit world in a WASI preview 2 component. In the case that it is an empty wit world, it's assumed that it is a WASI preview 1 component and we output a message accordingly.I also changed the heading from the claims inspect from
Module
toActor
andProvider Archive
toCapability Provider
. Keeping it as module just felt confusing when we'll be inspecting components too.Related Issues
Related to #336
Release Information
wash-lib 0.16.0
Consumer Impact
This is a backwards compatible change in
wash-cli
, but consumers of wash-lib that are instantiating the fullInspectCommand
struct will need to add thewit
boolean field.Testing
Unit Test(s)
Acceptance or Integration
Manual Verification
Module
Component