Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(*)!: Updates topics to the new standard #1466

Merged
merged 1 commit into from
Feb 16, 2024

Conversation

thomastaylor312
Copy link
Contributor

@thomastaylor312 thomastaylor312 commented Feb 6, 2024

This is a wide ranging PR that changes all the topics as described in #1108. This also involved removing the start and stop actor operations. While I was in different parts of the code I did some small "campfire rule" cleanups mostly of clippy lints and removal of clippy pedant mode.

Relates to #1108

@thomastaylor312 thomastaylor312 added the do-not-merge PR is not ready to be merged label Feb 6, 2024
@thomastaylor312 thomastaylor312 marked this pull request as draft February 6, 2024 02:05
@thomastaylor312
Copy link
Contributor Author

thomastaylor312 commented Feb 6, 2024

Couple of notes here:

  • Currently there is no way to test wash with these breaking changes as we don't have a host that it can test with for its integration tests. We need to decide what to do here, but I plan on testing manually soon.
  • 🚨 THIS IS NOT READY FOR MERGING. I mean, it should be mostly ready, but we want to cut a 0.82 first with the preview 2 stuff before we merge 1.0 breaking changes
  • There is a fast follow after this PR that will need to update the scale command to take an actor ID as well (like it used to) so that we can support scaling something that has already started without passing an actor ref. ID will be a required element because all entities will be getting identifiers in 1.0

Copy link
Member

@brooksmtownsend brooksmtownsend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple thoughts but overall the code looks real nice and clean.

crates/host/src/wasmbus/mod.rs Outdated Show resolved Hide resolved
crates/host/src/wasmbus/mod.rs Outdated Show resolved Hide resolved
crates/control-interface/src/broker.rs Outdated Show resolved Hide resolved
@connorsmith256
Copy link
Contributor

@thomastaylor312 heads up, I changed the description to remove resolves since we'll want the RFC to be closed once it has been converted to an ADR

@thomastaylor312 thomastaylor312 removed the do-not-merge PR is not ready to be merged label Feb 12, 2024
@thomastaylor312
Copy link
Contributor Author

To make it easier to get this in, I broke the wash changes out into a separate commit we can use later once we're ready to release an alpha version of the host. This is ready to review as soon as I rebase

@thomastaylor312 thomastaylor312 force-pushed the feat/topic_changes branch 2 times, most recently from f815bf3 to 5124e7b Compare February 12, 2024 21:16
@thomastaylor312 thomastaylor312 marked this pull request as ready for review February 12, 2024 21:17
@thomastaylor312
Copy link
Contributor Author

Also, marking as ready to review, but this shouldn't be merged before 0.82 is released

@thomastaylor312 thomastaylor312 force-pushed the feat/topic_changes branch 5 times, most recently from 5467187 to 293ef5f Compare February 14, 2024 23:49
crates/wash-cli/Cargo.toml Show resolved Hide resolved
crates/host/src/wasmbus/mod.rs Show resolved Hide resolved
@thomastaylor312 thomastaylor312 force-pushed the feat/topic_changes branch 2 times, most recently from 3bcddd3 to e5c12f3 Compare February 15, 2024 23:42
This is a wide ranging PR that changes all the topics as described
in wasmCloud#1108. This also involved removing the start and stop actor
operations. While I was in different parts of the code I did some small
"campfire rule" cleanups mostly of clippy lints and removal of
clippy pedant mode.

Resolves wasmCloud#1108

Signed-off-by: Taylor Thomas <taylor@cosmonic.com>
@brooksmtownsend brooksmtownsend merged commit 42d069e into wasmCloud:main Feb 16, 2024
47 checks passed
@thomastaylor312 thomastaylor312 deleted the feat/topic_changes branch February 16, 2024 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants