Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closing #131. Documentation updates. #151

Merged
merged 4 commits into from
Apr 13, 2021
Merged

Closing #131. Documentation updates. #151

merged 4 commits into from
Apr 13, 2021

Conversation

autodidaddict
Copy link
Member

@autodidaddict autodidaddict linked an issue Apr 12, 2021 that may be closed by this pull request
[BUG] Rust documentation is outdated and inaccurate #131
Closed
brooksmtownsend
brooksmtownsend requested changes Apr 12, 2021
View reviewed changes
Copy link
Member

@brooksmtownsend brooksmtownsend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of requested changes and questions. Aside from that, let me tell you, the documentation on this looks INCREDIBLE and I think these things are going to pay massive dividends when people are looking up wasmcloud.

crates/wasmcloud-host/src/host.rs Show resolved Hide resolved
crates/wasmcloud-host/src/host.rs Outdated Show resolved Hide resolved
crates/wasmcloud-host/src/host.rs Show resolved Hide resolved
crates/wasmcloud-host/src/host.rs Outdated Show resolved Hide resolved
crates/wasmcloud-host/src/host.rs Outdated Show resolved Hide resolved
crates/wasmcloud-host/src/host.rs Outdated Show resolved Hide resolved
crates/wasmcloud-host/src/host.rs Outdated Show resolved Hide resolved
crates/wasmcloud-host/src/lib.rs Outdated Show resolved Hide resolved
@autodidaddict
Copy link
Member Author

Thanks for the tip on using the bullet lists for the arguments. I like how it looks much better than just using a paragraph.

@brooksmtownsend
Copy link
Member

Looks like a merge may have gone wrong 😬

@autodidaddict
Copy link
Member Author

Looks like a merge may have gone wrong grimacing

Yep. Not sure what happened, other than me being foolish enough to try and fix the merge using the github editor rather than doing it old school.

@autodidaddict
Copy link
Member Author

@brooksmtownsend merge problem is all fixed.

brooksmtownsend
brooksmtownsend approved these changes Apr 13, 2021
View reviewed changes
Copy link
Member

@brooksmtownsend brooksmtownsend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG TM

@autodidaddict autodidaddict merged commit 59a87ef into main Apr 13, 2021
@autodidaddict autodidaddict deleted the docupdate branch April 13, 2021 13:10
rvolosatovs pushed a commit to rvolosatovs/wasmCloud that referenced this pull request Mar 21, 2023
Redis Expiration addition (wasmCloud#151)
0ee0a75 
* Redis Expiration addition

Signed-off-by: Esteban Gimbernat <egimbernat@sigaba.io>

* Cargo fmt fix

Signed-off-by: Esteban Gimbernat <egimbernat@sigaba.io>

* RedisKV patch version bump

Signed-off-by: Esteban Gimbernat <egimbernat@sigaba.io>

* Cargo FMT

Signed-off-by: Esteban Gimbernat <egimbernat@sigaba.io>

Co-authored-by: Esteban Gimbernat <egimbernat@sigaba.io>
rvolosatovs pushed a commit to rvolosatovs/wasmCloud that referenced this pull request Jul 21, 2023
@connorsmith256
Merge pull request wasmCloud#151 from connorsmith256/fix/typos
54ae778 
fix typos in examples
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brooksmtownsend brooksmtownsend brooksmtownsend approved these changes

@billyoung billyoung Awaiting requested review from billyoung

@ChrisRx ChrisRx Awaiting requested review from ChrisRx

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Rust documentation is outdated and inaccurate
2 participants
@autodidaddict @brooksmtownsend