Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(wash-lib): update command-group to v5 #1547

Merged
merged 1 commit into from
Feb 20, 2024

Conversation

brooksmtownsend
Copy link
Member

Feature or Problem

This PR updates the command-group dependency to v5, as v1 was pulling in an older version of the nix crate.

Related Issues

Release Information

next

Consumer Impact

Testing

Unit Test(s)

Acceptance or Integration

Manual Verification

Signed-off-by: Brooks Townsend <brooksmtownsend@gmail.com>
@brooksmtownsend brooksmtownsend requested a review from a team as a code owner February 20, 2024 14:16
@brooksmtownsend brooksmtownsend enabled auto-merge (rebase) February 20, 2024 14:16
Copy link
Member

@rvolosatovs rvolosatovs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't know much about the possible changes moving 4 major versions up - please make sure there are no breaking changes, which may not be caught by CI, but otherwise LGTM

@brooksmtownsend brooksmtownsend merged commit ceed8ea into main Feb 20, 2024
50 checks passed
@brooksmtownsend brooksmtownsend deleted the chore/update-command-group branch February 20, 2024 14:37
@brooksmtownsend
Copy link
Member Author

@rvolosatovs great questions, in the changelog 2 major version bumps were to bump the Rust MSRV, other APIs we don't use https://github.com/watchexec/command-group/blob/main/CHANGELOG.md 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants