fix(provider-bindgen): remove argument bundling #1653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Up until now, for wasmbus (i.e. msgpack) compatibility, bindgen has had to bundle arguments to functions into structs that were dynamically generated by bindgen. Given that wRPC can/must individually transmit arguments, we should no longer need this code, and can just deal with arguments and no bundling. This commit removes bundling and argument handling strategies options and functionality from bindgen. Signed-off-by: Victor Adossi <vadossi@cosmonic.com>
brooksmtownsend
approved these changes
Mar 12, 2024
vados-cosmonic
deleted the
fix(provider-bindgen)=remove-argument-bundling
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature or Problem
Up until now, for wasmbus (i.e. msgpack) compatibility, bindgen has had to bundle arguments to functions into structs that were dynamically generated by bindgen.
Given that wRPC can/must individually transmit arguments, we should no longer need this code, and can just deal with arguments and no bundling.
This commit removes bundling and argument handling strategies options and functionality from bindgen.
Related Issues
Release Information
Consumer Impact
Testing
Unit Test(s)
Acceptance or Integration
Manual Verification