feat: derive Encode and Subscribe, not EncodeSync
#1690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This does not support async yet, but should be good enough for now Signed-off-by: Roman Volosatovs <rvolosatovs@riseup.net>
Signed-off-by: Roman Volosatovs <rvolosatovs@riseup.net>
rvolosatovs
added
blocking
capability-providers
thomastaylor312
approved these changes
Mar 18, 2024
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature or Problem
While
EncodeandSubscribetraits do support async values, we do not currently support eitherstream<T>,future<T>orresourcetypes in WIT definitions we generate bindings for, therefore we can always assume that values we generate these implementations for do not have any asynchronous values embedded in them.Related Issues
Release Information
Consumer Impact
This allows binding generation for
option,resultetc. types - everything is supported except for preview3 async and resources.Testing
Unit Test(s)
Acceptance or Integration
Manual Verification