Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to wasmcloud:messaging in providers #1693

Merged
merged 1 commit into from
Mar 18, 2024

Conversation

rvolosatovs
Copy link
Member

@rvolosatovs rvolosatovs commented Mar 18, 2024

Feature or Problem

Switch to wasmcloud:messaging in providers (https://github.com/wasmCloud/messaging/)

That's the interface, which was implemented in the host for a long time - compared to in-tree interface it also provides error handling among other things.

Related Issues

Removed request-multi from the interface in wasmCloud/messaging#4 for simplicity and minimizing API surface - I don't think we ever really used it

Blocked on #1690

Release Information

Consumer Impact

Testing

Unit Test(s)

Existing tests cover NATS provider, kafka was untested, and still is

Acceptance or Integration

Manual Verification

@rvolosatovs rvolosatovs requested review from a team as code owners March 18, 2024 14:48
@rvolosatovs rvolosatovs marked this pull request as draft March 18, 2024 14:48
@rvolosatovs rvolosatovs force-pushed the feat/wrpc-messaging branch 3 times, most recently from 2f1bdfb to 931f65c Compare March 18, 2024 14:54
@rvolosatovs rvolosatovs added blocked capability-providers Issues related to in-tree capability providers labels Mar 18, 2024
@rvolosatovs rvolosatovs marked this pull request as ready for review March 18, 2024 16:09
@rvolosatovs rvolosatovs enabled auto-merge (rebase) March 18, 2024 16:21
@rvolosatovs rvolosatovs force-pushed the feat/wrpc-messaging branch 2 times, most recently from 9dba222 to ef676c9 Compare March 18, 2024 16:41
Also implement statically invoking the `handler` on components in the
host

Signed-off-by: Roman Volosatovs <rvolosatovs@riseup.net>
@rvolosatovs rvolosatovs merged commit 716d251 into wasmCloud:main Mar 18, 2024
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked capability-providers Issues related to in-tree capability providers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants