Remove cluster issuers, bump to 1.0.0-rc.1 #1828
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brooksmtownsend
changed the title
brooksmtownsend
force-pushed
the
chore/remove-cluster-issuers
branch
from
c553b0e
to
4efa453
Compare
ricochet
approved these changes
Apr 8, 2024
thomastaylor312
requested changes
Apr 8, 2024
brooksmtownsend
force-pushed
the
chore/remove-cluster-issuers
branch
from
4efa453
to
5e01f20
Compare
Signed-off-by: Brooks Townsend <brooksmtownsend@gmail.com>
Signed-off-by: Brooks Townsend <brooksmtownsend@gmail.com> tell people no Signed-off-by: Brooks Townsend <brooksmtownsend@gmail.com>
Signed-off-by: Brooks Townsend <brooksmtownsend@gmail.com>
brooksmtownsend
force-pushed
the
chore/remove-cluster-issuers
branch
from
5e01f20
to
b62b8a2
Compare
thomastaylor312
approved these changes
Apr 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature or Problem
This PR removes the cluster_seed and cluster_issuers command line flags (and internal plumbing), and takes the chore to bump to wasmCloud 1.0.0-rc.1 when we're ready 馃殌
Related Issues
See #1220 for the motivation behind cluster seed and cluster issuers being removed in favor of response signing verification.
Release Information
Consumer Impact
Because the
cluster_issuersfield in the HostData struct for providers is not something that serde can deserialize if it's missing, we will pass an empty vec until we can ensure that we can release a new version of all of our capability providers that don't depend on this field being passed.Testing
Unit Test(s)
Acceptance or Integration
Manual Verification