Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(wash-lib): expect wit-bindgen-go 0.24.0 files #1836

Merged
merged 1 commit into from
Apr 8, 2024

Conversation

brooksmtownsend
Copy link
Member

Feature or Problem

This PR modifies our expected files from golang bindgen to match what comes out of wit-bindgen 0.24, mostly adding the types file and especting for the world to be sanitized with underscores.

Related Issues

Fixes the tests in #1829 and #1828

Release Information

Consumer Impact

Testing

Unit Test(s)

Acceptance or Integration

Manual Verification

@brooksmtownsend brooksmtownsend requested a review from a team as a code owner April 8, 2024 18:37
@brooksmtownsend brooksmtownsend enabled auto-merge (rebase) April 8, 2024 18:37
Signed-off-by: Brooks Townsend <brooksmtownsend@gmail.com>
@brooksmtownsend brooksmtownsend merged commit c1cf682 into main Apr 8, 2024
74 checks passed
@brooksmtownsend brooksmtownsend deleted the fix/golang-bindgen-test branch April 8, 2024 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants