Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle disconnected NATS connection better #2174

Merged
merged 3 commits into from
May 24, 2024
Merged

Conversation

lachieh
Copy link
Contributor

@lachieh lachieh commented May 24, 2024

Feature or Problem

Found that the nats connection wasn't reconnecting if it failed to connect initially, or was disconnected for some reason. This makes the connection attempt to reconnect if a new request is made while it is disconnected/errored.

@lachieh lachieh requested a review from a team as a code owner May 24, 2024 00:01
@lachieh lachieh changed the title Lattice client updates Handle disconnected NATS connection better May 24, 2024
…on is disconnected

Signed-off-by: Lachlan Heywood <lachieh@users.noreply.github.com>
…thods

Signed-off-by: Lachlan Heywood <lachieh@users.noreply.github.com>
Signed-off-by: Lachlan Heywood <lachieh@users.noreply.github.com>
Copy link
Contributor

@vados-cosmonic vados-cosmonic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@lachieh lachieh merged commit ba7e63e into main May 24, 2024
47 checks passed
@lachieh lachieh deleted the lattice-client-updates branch May 24, 2024 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants