New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: enable updating host labels via the control interface #780
feat: enable updating host labels via the control interface #780
Conversation
…no-0.4.30 build(deps): Bump chrono from 0.4.29 to 0.4.30
b2a6f71
to
daf0543
Compare
Signed-off-by: Connor Smith <connor.smith.256@gmail.com>
daf0543
to
9eb0885
Compare
Signed-off-by: Connor Smith <connor.smith.256@gmail.com>
9eb0885
to
9594204
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm happy with this, and I think the topics fit into our current structure. We may want to change them when we audit the control interface topics but that's okay
Signed-off-by: Connor Smith <connor.smith.256@gmail.com>
0e6b21e
to
a9b8b27
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
Feature or Problem
This adds two new topics to the host's control interface:
wasmbus.ctl.{lattice_id}.labels.{host_id}.{put/del}
. Publishing on these topics allows users to dynamically adjust the target host's labelsRelated Issues
Relates to #692
Release Information
Minor bump to the control interface crate as well as the host. Functionality via wash to be added after both of the former are released
Consumer Impact
This is a potentially a step in the direction of enabling lame-duck mode on the host (we could use a special label to convey that intent)
Testing
Unit Test(s)
Acceptance or Integration
I exercised put and delete via the wasmbus tests
Manual Verification