Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: stop sending linkdef events on startup #805

Merged

Conversation

connorsmith256
Copy link
Contributor

Feature or Problem

This PR splits processing historical lattice metadata entries into two parts:

  • on startup, the host reads all entries out of the bucket and initializes its cache of link defs/claims. It should not publish link def put/deleted events for historical entries
  • on startup, the host starts listening to new entries. For new entries, the host should publish link def put/deleted events

Release Information

Next

Consumer Impact

The host should simply emit fewer events on startup

Testing

Unit Test(s)

Acceptance or Integration

Manual Verification

Ran the host, confirmed a bunch of process_entry logs were emitted, but no linkdef_set events were, until I ran wash link put

@connorsmith256 connorsmith256 requested a review from a team as a code owner October 25, 2023 23:50
crates/host/src/wasmbus/mod.rs Outdated Show resolved Hide resolved
Signed-off-by: Connor Smith <connor.smith.256@gmail.com>
@connorsmith256 connorsmith256 merged commit e9a3917 into wasmCloud:main Oct 26, 2023
23 checks passed
@connorsmith256 connorsmith256 deleted the fix/duplicate-linkdef-events branch October 26, 2023 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants