-
Notifications
You must be signed in to change notification settings - Fork 789
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename wasm_instance_new()’s “traps” argument to “trap”. #2478
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great catch!
bors r+ |
2478: Rename wasm_instance_new()’s “traps” argument to “trap”. r=syrusakbary a=FGasper Issue #2472 # Description This clarifies a bit how to properly use the error-handling mechanism in `wasm_instance_new()`, which only produces 0 or 1 traps, not 2+ as the name “traps” implies. # Review - [ ] Add a short description of the change to the CHANGELOG.md file Co-authored-by: Felipe Gasper <felipe@felipegasper.com>
d8cd757
to
02c9eb7
Compare
Canceled. |
bors r+ |
2478: Rename wasm_instance_new()’s “traps” argument to “trap”. r=syrusakbary a=FGasper Issue #2472 # Description This clarifies a bit how to properly use the error-handling mechanism in `wasm_instance_new()`, which only produces 0 or 1 traps, not 2+ as the name “traps” implies. # Review - [ ] Add a short description of the change to the CHANGELOG.md file Co-authored-by: Felipe Gasper <felipe@felipegasper.com>
Build failed: |
02c9eb7
to
fcbc174
Compare
bors r+ |
2478: Rename wasm_instance_new()’s “traps” argument to “trap”. r=syrusakbary a=FGasper Issue #2472 # Description This clarifies a bit how to properly use the error-handling mechanism in `wasm_instance_new()`, which only produces 0 or 1 traps, not 2+ as the name “traps” implies. # Review - [ ] Add a short description of the change to the CHANGELOG.md file Co-authored-by: Felipe Gasper <felipe@felipegasper.com>
Build failed: |
fcbc174
to
4255387
Compare
bors r+ |
🔒 Permission denied Existing reviewers: click here to make FGasper a reviewer |
bors r+ |
@@ -9,6 +9,8 @@ Looking for changes that affect our C API? See the [C API Changelog](lib/c-api/C | |||
## **[Unreleased]** | |||
|
|||
### Changed | |||
- [#2478](https://github.com/wasmerio/wasmer/pull/2478) Rename `traps` input to `wasm_instance_new()` to `trap`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is incorrect, it should have been written in the lib/c-api/CHANGELOG.md
file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in #2481.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry! I noticed that only after committing. Thank you for fixing it.
Issue #2472
Description
This clarifies a bit how to properly use the error-handling mechanism in
wasm_instance_new()
, which only produces 0 or 1 traps, not 2+ as the name “traps” implies.Review