Support for the WASI ABI. #299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjfish
reviewed
Mar 28, 2019
| @@ -63,7 +63,16 @@ impl Instance { | |||
| // Initialize the vm::Ctx in-place after the backing | |||
| // has been boxed. | |||
| unsafe { | |||
| *inner.vmctx = vm::Ctx::new(&mut inner.backing, &mut inner.import_backing, &module) | |||
| *inner.vmctx = match imports.call_state_creator() { | |||
| Some((data, dtor)) => vm::Ctx::new_with_data( | |||
There was a problem hiding this comment.
dtor? maybe destructor or finalizer?
There was a problem hiding this comment.
Yeah, either of those is fine. dtor was just short and it's common in the c++ world.
bjfish
reviewed
Mar 28, 2019
|
|
||
| #[allow(clippy::mut_from_ref)] | ||
| fn get_wasi_state(ctx: &Ctx) -> &mut WasiState { | ||
| unsafe { &mut *(ctx.data as *mut WasiState) } |
There was a problem hiding this comment.
One idea: we could differentiate between ModuleState, InstanceState, FunctionState (if we add that).
added 12 commits
April 2, 2019 15:29
xmclark
approved these changes
Apr 3, 2019
lib/wasi/src/state.rs
Outdated
| Ok(Self { | ||
| repo: RepoOpener::new() | ||
| .create(true) | ||
| .open("mem://foo", "") |
There was a problem hiding this comment.
let's call it something else
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Apr 4, 2019
299: Support for the WASI ABI. r=xmclark a=lachlansneff part of #297 Co-authored-by: Lachlan Sneff <lachlan.sneff@gmail.com> Co-authored-by: Mark McCaskey <mark@wasmer.io> Co-authored-by: bors[bot] <bors[bot]@users.noreply.github.com> Co-authored-by: Mark McCaskey <markmccaskey@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of #297