Fix support for env vars (put, set, unset) #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
syrusakbary
force-pushed
the
fix/emscripten-env
branch
from
6bf3fd5
to
38bd62b
Compare
# Conflicts: # build/emtests.rs # src/emtests/mod.rs
syrusakbary
changed the title
bjfish
approved these changes
Dec 22, 2018
|
Good call! I'll mark them as implemented now |
MarkMcCaskey
pushed a commit
that referenced
this pull request
Apr 14, 2020
nlewycky
added a commit
that referenced
this pull request
Aug 13, 2020
Add llvm 'readonly' attribute to calls of the memory size function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
emtests/env.ctest file, with the corresponding emtest. This emtest is currently failing. When it passes we should be good to mergeSteps to run reproduce the issue: