-
Notifications
You must be signed in to change notification settings - Fork 278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Publishing benchmarks for graphs #740
Conversation
BENCHMARKS
|
Codecov Report
@@ Coverage Diff @@
## master #740 +/- ##
==========================================
+ Coverage 79.25% 79.40% +0.15%
==========================================
Files 104 104
Lines 9046 9054 +8
==========================================
+ Hits 7169 7189 +20
+ Misses 1877 1865 -12 see 16 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
@alvicsam thanks for implementing this so quickly and sorry for replying to late! The graphs look pretty cool and the website display is clean. I have a few extra requests if possible. 😇
![]() With the zoom talk above it would be really cool with smaller zoom to have a high-level overview of all graphs and make it possible to click on them to enlarge a single graph for inspection if necessary. Is that possible? |
Unfortunately I couldn't find this option in the GHA
With this action it's not possible, it's hardcoded there
No, this is how GHA generates the page with result. I've checked and have the same output: 2 columns with graphs on a big screen and 1 column on my laptop |
Would it maybe be possible to write feature request issues for this? Not that important though.
Hmm, again I think we could write feature request issues since the ns/iter is really not a great default for everything anyways imo. Sometimes for example you measure throughput or measure network stuff which usually goes with ms/iter. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for implementing this so quickly @alvicsam! Sorry for taking unusually long to reply and review.
.docker-env: &docker-env | ||
image: "paritytech/ci-linux:staging" | ||
.docker-env: | ||
image: "paritytech/ci-unified:bullseye-1.71.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What are the effects of this and why was this changed/needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We replaced ci-linux
with ci-unified
. It has transparent tags naming, flexible choice of
Rust versions, and so on. More - https://hub.docker.com/repository/docker/paritytech/ci-unified
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are switching to our new ci-unified
image. We decided to have "one for all" image and finally added versioning to it.
@alvicsam Is this ready for merge? |
yes |
Thanks a lot @alvicsam for this! 🚀 |
PR adds gitlab and github jobs that run benchmarks for master and create nice graphs that can be found here
close https://github.com/paritytech/ci_cd/issues/848