New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Figure out Wasp's package.lock.json story #559
Comments
We could consider splitting Wasp into two folders:
I have a feeling we'll start encountering this problem more often as time goes by and we start integrating with more and more packages. |
For grouping all the files that we generate but need to be part of the
project anyway and be committed? Sounds good! Maybe a bit cooler name but
this one is also not so bad!
…On Mon, 4 Jul 2022, 12:01 Filip Sodić, ***@***.***> wrote:
We could consider splitting Wasp into two folders:
- .wasp/ - This one remains hidden and contains the build artifacts.
Users to not include it in version control.
- wasp-info (with a hopefully better name) - A visible directory
containing all the persistent stuff (package-lock.json, migrations,
and anything else we need in the future). Users would include this one in
their version control.
I have a feeling we'll start encountering this problem more often as time
goes by and we start integrating with more and more packages.
—
Reply to this email directly, view it on GitHub
<#559 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AALXFB2YENVDEE63NKPKDYDVSKZALANCNFSM5TEE3AWA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Related to #734 somewhat. |
Related issue, where the fact that we don't have package-lock.json for our server code (framework code, so generated by us) caused issues: #1724 . |
Btw, one thing is storing package-lock files, but we actually also have to be able to use them! This is normally done with So, if I want to run my Wasp in CI, and I want to install deps from package-lock.json, but not only the top level one (client code), but also based on package-lock.json's of framework code (web-app and server), how can I do that? What should probably happen is that |
We want to offer same guarantees as package.lock.json does, which is ensuring reproducible builds.
How do we do that with Wasp? Do we copy the package.lock.json files up from generated project files to the source? Or do we use some other abstraction on top of it? Should we use
yarn
instead odnpm
since it allegedly has better support (cross platform,fevent
issues are avoided byyarn
but unsolved bynpm
).The text was updated successfully, but these errors were encountered: