-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds Keycloak OAuth provider #1876
Conversation
1cbb6dd
to
fdf33df
Compare
843bf03
to
6c8e511
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good, found only a couple of small docs errors to correct (and some suggestions you can consider).
Other than that, LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have any specific comments (besides the discussion we're having here: #1851 (comment)
} | ||
|
||
// A layout component to center the content | ||
export function Layout({ children }: { children: React.ReactNode }) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you should import React
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Types work just fine even without importing it, I've just tested it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm, strange. But if everything works (hope you checked build), then no problem.
I'd still probably do:
import { ReactNode } from 'react';
But it's just a matter of personal style.
d5754c8
to
0b1e929
Compare
I'll merge this after we merge the Google and Github changes and docs. |
f418c91
to
38850bd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
38850bd
to
3d6e57a
Compare
5813990
to
13b0c5c
Compare
Signed-off-by: Mihovil Ilakovac <mihovil@ilakovac.com>
3d6e57a
to
4cda0c6
Compare
Left to do