Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Keycloak OAuth provider #1876

Merged
merged 1 commit into from
Mar 18, 2024
Merged

Conversation

infomiho
Copy link
Contributor

@infomiho infomiho commented Mar 11, 2024

  • Adds the Keycloak OAuth provider using Arctic.
  • It extends all of the place where we had Google and Github to include Keycloak (icons, buttons, Wasp Studio etc.)

Left to do

  • Update the docs to include Keycloak info
      [ Server ] {
      [ Server ]   profile: {
      [ Server ]     sub: '5adba8fc-3ea6-445a-a379-13f0bb0b6969',
      [ Server ]     email_verified: true,
      [ Server ]     name: 'Test User',
      [ Server ]     preferred_username: 'test',
      [ Server ]     given_name: 'Test',
      [ Server ]     family_name: 'User',
      [ Server ]     email: 'test@example.com'
      [ Server ]   }
      [ Server ] }
  • Update Keycloak impl to match the latest impl of other providers

@infomiho infomiho force-pushed the keycloak-oauth-provider branch 2 times, most recently from 843bf03 to 6c8e511 Compare March 14, 2024 20:16
@infomiho infomiho added the auth label Mar 14, 2024
Copy link
Contributor

@sodic sodic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good, found only a couple of small docs errors to correct (and some suggestions you can consider).

Other than that, LGTM.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have any specific comments (besides the discussion we're having here: #1851 (comment)

web/docs/auth/social-auth/keycloak.md Outdated Show resolved Hide resolved
web/docs/auth/social-auth/keycloak.md Outdated Show resolved Hide resolved
web/docs/auth/social-auth/keycloak.md Outdated Show resolved Hide resolved
}

// A layout component to center the content
export function Layout({ children }: { children: React.ReactNode }) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you should import React.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Types work just fine even without importing it, I've just tested it

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, strange. But if everything works (hope you checked build), then no problem.

I'd still probably do:

import { ReactNode } from 'react';

But it's just a matter of personal style.

web/docs/auth/social-auth/keycloak.md Outdated Show resolved Hide resolved
web/docs/auth/social-auth/keycloak.md Outdated Show resolved Hide resolved
web/docs/auth/social-auth/keycloak.md Outdated Show resolved Hide resolved
web/docs/auth/social-auth/keycloak.md Show resolved Hide resolved
@infomiho
Copy link
Contributor Author

I'll merge this after we merge the Google and Github changes and docs.

@infomiho infomiho force-pushed the keycloak-oauth-provider branch 2 times, most recently from f418c91 to 38850bd Compare March 16, 2024 20:40
Copy link
Contributor

@sodic sodic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Base automatically changed from miho-arctic-integration to arctic-feature March 18, 2024 11:33
Signed-off-by: Mihovil Ilakovac <mihovil@ilakovac.com>
@infomiho infomiho merged commit 97cdcee into arctic-feature Mar 18, 2024
6 checks passed
@infomiho infomiho deleted the keycloak-oauth-provider branch March 18, 2024 11:38
infomiho added a commit that referenced this pull request Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants