Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Authentication generation #74

Merged
merged 5 commits into from
Oct 19, 2020
Merged

Authentication generation #74

merged 5 commits into from
Oct 19, 2020

Conversation

matijaSos
Copy link
Contributor

No description provided.

@matijaSos matijaSos changed the title Matija auth gen Authentication generation Oct 12, 2020
@matijaSos matijaSos marked this pull request as draft October 12, 2020 11:42
matijaSos
matijaSos commented Oct 12, 2020
View reviewed changes
waspc/data/Generator/templates/server/src/core/auth.js Outdated Show resolved Hide resolved
waspc/data/Generator/templates/server/src/core/auth.js Outdated Show resolved Hide resolved
waspc/data/Generator/templates/server/src/routes/auth/login.js Outdated Show resolved Hide resolved
waspc/src/Generator/ServerGenerator/AuthG.hs Outdated Show resolved Hide resolved
waspc/src/Generator/ServerGenerator/AuthG.hs Outdated Show resolved Hide resolved
waspc/src/Generator/ServerGenerator.hs Outdated Show resolved Hide resolved
waspc/data/Generator/templates/react-app/src/auth/logout.js Outdated Show resolved Hide resolved
waspc/examples/todoApp/ext/pages/Signup.js Outdated Show resolved Hide resolved
waspc/examples/todoApp/ext/queries.js Show resolved Hide resolved
waspc/data/Generator/templates/react-app/src/auth/login.js Outdated Show resolved Hide resolved
@matijaSos matijaSos marked this pull request as ready for review October 13, 2020 14:52
Martinsos
Martinsos approved these changes Oct 14, 2020
View reviewed changes
Copy link
Member

@Martinsos Martinsos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, huge PR and huge feature :)! There are no major comments really, a lot of small onces. Maybe the most interesting is one with entities: [User] that is not mandatory.

waspc/data/Generator/templates/react-app/src/api.js Outdated Show resolved Hide resolved
waspc/data/Generator/templates/react-app/src/api.js Outdated Show resolved Hide resolved
waspc/data/Generator/templates/react-app/src/api.js Show resolved Hide resolved
waspc/data/Generator/templates/react-app/src/api.js Outdated Show resolved Hide resolved
waspc/data/Generator/templates/react-app/src/auth/_useUser.js Outdated Show resolved Hide resolved
waspc/examples/todoApp/todoApp.wasp Show resolved Hide resolved
waspc/examples/todoApp/todoApp.wasp Show resolved Hide resolved
waspc/src/Generator/ServerGenerator.hs Outdated Show resolved Hide resolved
waspc/src/Generator/ServerGenerator/AuthG.hs Outdated Show resolved Hide resolved
waspc/src/Wasp.hs Outdated Show resolved Hide resolved
Martinsos
Martinsos approved these changes Oct 19, 2020
View reviewed changes
Copy link
Member

@Martinsos Martinsos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, all looks good to me!

@matijaSos matijaSos merged commit 6a59804 into master Oct 19, 2020
@matijaSos matijaSos deleted the matija-auth-gen branch October 19, 2020 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Martinsos Martinsos Martinsos approved these changes

Assignees

@matijaSos matijaSos

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@matijaSos @Martinsos