New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Helper for CheckboxSelectMultiple widget which allows user to select/… #879
Conversation
…unselect all available options.
# tty: true | ||
# Following allows to execute `docker attach feder_web_1` | ||
# necessary when using ipdb in development: | ||
stdin_open: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest comment out that back. It's out of scope of that PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know, it's out of scope but it's just about to be merged into master. I think it's useful to save some time. To be honest, this super correctness makes me work much slower and I don't like the idea of making separate branch just for things so small. I mean, there is nothing unclear in this case, which would lead to any problems in my opinion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ja skomentowałem, bo odniosłem wrażenie, że zacommitowałeś odkomentowane przypadkiem. Jak wprowadzałeś zacommitowane to się nie odezwałem.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rozumiem, w tym przypadku akurat celowo odkomentowałem, bo pomyślałem, że tak będzie wygodniej dla wszystkich deweloperów. Raczej niczemu to nie szkodzi, bo Dockera mamy tylko dla developmentu, a ułatwia debug. Chyba, że o czymś nie wiem?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Jak ułatwia i testy przechodzą to niech będzie.
@@ -556,8 +556,7 @@ | |||
"colorette": { | |||
"version": "1.2.1", | |||
"resolved": "https://registry.npmjs.org/colorette/-/colorette-1.2.1.tgz", | |||
"integrity": "sha512-puCDz0CzydiSYOrnXpz/PKd69zRrribezjtE9yd4zvytoRc8+RY/KJPvtPFKZS3E3wP6neGyMe0vOTlHO5L3Pw==", | |||
"dev": true | |||
"integrity": "sha512-puCDz0CzydiSYOrnXpz/PKd69zRrribezjtE9yd4zvytoRc8+RY/KJPvtPFKZS3E3wP6neGyMe0vOTlHO5L3Pw==" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Zmiany w tym pliku psują build.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Faktycznie, musiałem docommitować.
…unselect all available options.