Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://guides.rubyonrails.org/engines.html#routes
If you look at the engines docs for rails, the recommended implementation for an engine is to specify
isolate_namespace SomeEngineName
. There is a subtlety that requires you to specifymain_app.url_helper_x
in any view or partial that is rendered by engine machinery... we felt as if the gem should handle the heavy lifting and not require the client application to know that the engine has such nuances. This requires you to specify the namespace in places like routes, controller references, view paths, etc -- in the gem. See subtle paragraph that took some time to find(from the doc above):