Skip to content
This repository has been archived by the owner on Mar 12, 2024. It is now read-only.

Feature/simplified labeling #376

Closed
wants to merge 5 commits into from
Closed

Conversation

EstebanDalelR
Copy link
Member

Description

Simplifies labeling code

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Chore: cleanup/renaming, etc
  • RFC

Notes

Acceptance

Copy link

vercel bot commented Nov 13, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
watermelon ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 23, 2023 4:32pm

}
)
.catch((error) => {
console.error("Label not found", error);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file contains at least one console log. Please remove any present.

Copy link

watermelon-copilot-for-code-review bot commented Nov 13, 2023

Watermelon AI Summary

This pull request introduces a new feature that streamlines the process of adding labels, by improving the code structure, enhancing the logging for better traceability, removing global issue number constraints, and transitioning to asynchronous functions for improved efficiency.

GitHub PRs

Click here to login to Jira
Click here to login to Confluence
No results found in Slack Threads :(

Notion Pages

Linear Tickets

Click here to login to Asana
watermelon is an open repo and Watermelon will serve it for free.
🍉🫶
Have you starred Watermelon?

Copy link
Collaborator

@baristaGeek baristaGeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This approach fails to label PRs without a label. How I arrived to this conclusion:

  1. I opened [TEST] Test edge case #378, the removed its label
  2. Ran this branch with 378's payload. It edited the PR comment, but didn't label
  3. Ran the dev branch with 378's payload. The PR got re-labeled.

@@ -1,11 +1,7 @@
const { Configuration, OpenAIApi } = require("openai");

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file contains at least one console log. Please remove any present.

WatermelonAI Summary

This PR simplifies labeling code by fixing imports and removing the requirement for issue numbers as it's a global change. It's a new feature that adds functionality, involving cleaning up and renaming.

GitHub PRs

Click here to login to Jira
Click here to login to Confluence
No results found in Slack Threads :(

Notion Pages

No results found in Linear Tickets :(

Click here to login to Asana
watermelon is an open repo and Watermelon will serve it for free.
🍉🫶

WatermelonAI Summary

This PR simplifies the labeling code by fixing imports, simplifying label posting, removing the issue number requirement, and improving logging. It is a new feature that adds functionality and includes cleanup/renaming.

GitHub PRs

Click here to login to Jira
Click here to login to Confluence
No results found in Slack Threads :(

Notion Pages

No results found in Linear Tickets :(

Click here to login to Asana
watermelon is an open repo and Watermelon will serve it for free.
🍉🫶
Try us on VSCode!

@baristaGeek
Copy link
Collaborator

Just wanted to update that I just tried with #391 and still getting the same unexpected result

@baristaGeek
Copy link
Collaborator

It's still not working. Let's not worry about this if it's complicated to make it work with this idiomatic change.

Uploading Screen Recording 2023-11-24 at 4.11.30 PM.mov…

@baristaGeek
Copy link
Collaborator

Screen.Recording.2023-11-24.at.4.11.30.PM.mov

Copy link
Collaborator

@baristaGeek baristaGeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still not working, I added a video showing my testing process. I hope that helps.

But if it's hard, let's not worry about this.

@EstebanDalelR
Copy link
Member Author

Closing for now

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants