-
Notifications
You must be signed in to change notification settings - Fork 12
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
} | ||
) | ||
.catch((error) => { | ||
console.error("Label not found", error); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file contains at least one console log. Please remove any present.
Watermelon AI SummaryThis pull request introduces a new feature that streamlines the process of adding labels, by improving the code structure, enhancing the logging for better traceability, removing global issue number constraints, and transitioning to asynchronous functions for improved efficiency. GitHub PRs
Click here to login to Jira Notion PagesLinear TicketsClick here to login to Asana |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This approach fails to label PRs without a label. How I arrived to this conclusion:
- I opened [TEST] Test edge case #378, the removed its label
- Ran this branch with 378's payload. It edited the PR comment, but didn't label
- Ran the dev branch with 378's payload. The PR got re-labeled.
@@ -1,11 +1,7 @@ | |||
const { Configuration, OpenAIApi } = require("openai"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file contains at least one console log. Please remove any present.
WatermelonAI SummaryThis PR simplifies labeling code by fixing imports and removing the requirement for issue numbers as it's a global change. It's a new feature that adds functionality, involving cleaning up and renaming. GitHub PRs
Click here to login to Jira Notion PagesNo results found in Linear Tickets :( Click here to login to Asana |
WatermelonAI SummaryThis PR simplifies the labeling code by fixing imports, simplifying label posting, removing the issue number requirement, and improving logging. It is a new feature that adds functionality and includes cleanup/renaming. GitHub PRs
Click here to login to Jira Notion PagesNo results found in Linear Tickets :( Click here to login to Asana |
Just wanted to update that I just tried with #391 and still getting the same unexpected result |
It's still not working. Let's not worry about this if it's complicated to make it work with this idiomatic change. Uploading Screen Recording 2023-11-24 at 4.11.30 PM.mov… |
Screen.Recording.2023-11-24.at.4.11.30.PM.mov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still not working, I added a video showing my testing process. I hope that helps.
But if it's hard, let's not worry about this.
Closing for now |
Description
Simplifies labeling code
Type of change
Notes
Acceptance