Skip to content
This repository has been archived by the owner on Mar 12, 2024. It is now read-only.

Fix/prevent double console log commenting #377

Merged
merged 10 commits into from
Nov 15, 2023

Conversation

EstebanDalelR
Copy link
Member

Description

Prevents double posting and reduces complexity

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Chore: cleanup/renaming, etc
  • RFC

Notes

Acceptance

Copy link

vercel bot commented Nov 14, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
watermelon ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 15, 2023 4:50pm

@@ -17,6 +17,21 @@ const app = new App({
appId: process.env.GITHUB_APP_ID!,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file contains at least one console log. Please remove any present.

WatermelonAI Summary

This PR prevents double console log commenting, reducing complexity. It includes code changes to move a constant prompt, extract a hash getter, await a result, fix a type, and extract text. Overall, it aims to fix a bug and improve the codebase.

No results found in GitHub PRs :(

Click here to login to Jira
Click here to login to Confluence
No results found in Slack Threads :(

Notion Pages

No results found in Linear Tickets :(

Click here to login to Asana
watermelon is an open repo and Watermelon will serve it for free.
🍉🫶
Try us on any JetBrains IDE!

WatermelonAI Summary

This PR prevents the double posting of console logs by moving a constant prompt, extracting a hash getter, awaiting the result, fixing a type, extracting text, and removing unused imports.
It also reduces complexity and includes a bug fix and code cleanup. Overall, it improves the logging functionality and code quality.

No results found in GitHub PRs :(

Click here to login to Jira
Click here to login to Confluence
No results found in Slack Threads :(

Notion Pages

No results found in Linear Tickets :(

Click here to login to Asana
watermelon is an open repo and Watermelon will serve it for free.
🍉🫶
Try us on VSCodium!

WatermelonAI Summary

This PR fixes the issue of double console log commenting by preventing double posting and reducing complexity. It includes several commits that move a constant prompt, extract a hash getter, await a result, fix a type, extract text, remove unused imports, and rewrite a diffing function. The PR also includes acceptance criteria and references the contributing guidelines and code of conduct.

GitHub PRs

Click here to login to Jira
Click here to login to Confluence
No results found in Slack Threads :(

Notion Pages

No results found in Linear Tickets :(

Click here to login to Asana
watermelon is an open repo and Watermelon will serve it for free.
🍉🫶

return result.data.head.sha;
})
.catch((err) => {
console.log(err);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file contains at least one console log. Please remove any present.

WatermelonAI Summary

This PR fixes a bug related to double posting and reduces complexity. It includes various commits that involve moving, extracting, fixing, and rewriting functions. The goal is to prevent double console log commenting in order to improve the functionality of the system.

GitHub PRs

Click here to login to Jira
Click here to login to Confluence
No results found in Slack Threads :(

Notion Pages

Linear Tickets

Click here to login to Asana
watermelon is an open repo and Watermelon will serve it for free.
🍉🫶
Try us on any JetBrains IDE!

WatermelonAI Summary

This PR fixes a bug related to double posting and reduces complexity. It includes multiple commits that improve different parts of the code, such as extracting functions, fixing types, removing unused imports, and rewriting a diffing function. Overall, it aims to enhance the codebase and prevent the issue of double console log commenting.

GitHub PRs

Click here to login to Jira
Click here to login to Confluence
No results found in Slack Threads :(

Notion Pages

No results found in Linear Tickets :(

Click here to login to Asana
watermelon is an open repo and Watermelon will serve it for free.
🍉🫶

Copy link
Collaborator

@baristaGeek baristaGeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested on #379 and it LGTM. I sent various Postman payloads and didn't get multiple comments.

return result.data.head.sha;
})
.catch((err) => {
console.log(err);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file contains at least one console log. Please remove any present.

WatermelonAI Summary

This PR fixes an issue preventing double console log commenting. It includes various changes to the code, such as moving the constant prompt, extracting a hash getter, fixing a type, extracting text, removing unused imports, rewriting a diffing function, fixing a function, and using falsy values to return. These changes aim to reduce complexity and improve the code's functionality.

GitHub PRs

Click here to login to Jira
Click here to login to Confluence
No results found in Slack Threads :(

Notion Pages

No results found in Linear Tickets :(

Click here to login to Asana
watermelon is an open repo and Watermelon will serve it for free.
🍉🫶

return result.data.head.sha;
})
.catch((err) => {
console.log(err);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file contains at least one console log. Please remove any present.

WatermelonAI Summary

This PR fixes a bug that caused double console log commenting. It moves a constant prompt, extracts a hash getter, awaits a result, fixes a type, extracts text, removes unused imports, rewrites a diffing function, fixes a function, and uses falsy values to return.

GitHub PRs

Click here to login to Jira
Click here to login to Confluence
No results found in Slack Threads :(

Notion Pages

No results found in Linear Tickets :(

Click here to login to Asana
watermelon is an open repo and Watermelon will serve it for free.
🍉🫶

@EstebanDalelR EstebanDalelR merged commit 5c2427e into dev Nov 15, 2023
3 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants