Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactored Code to support Assistant V2 #6

Merged
merged 2 commits into from Dec 10, 2018

Conversation

stevenpkg
Copy link

  • API code changes to Assistant to support session id
  • Update context to latest version

* API code changes to Assistant to support session id
* Update context to latest version
@stevenpkg
Copy link
Author

Adding @Oliver-I

Copy link
Contributor

@germanattanasio germanattanasio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@germanattanasio
Copy link
Contributor

@stevenpkg can you update the README.md with the new instructions?
I would like for you to also test this with an app running in the IBM Cloud rather than locally so that we can be sure it will work as expected

@stevenpkg
Copy link
Author

@germanattanasio you can test a dev version here

http://watson-assistant-intermediate-dev.mybluemix.net/

What changes to the readme would you like to see done?

@germanattanasio
Copy link
Contributor

If you can say that this demo is using Assistant V2(link to the documentation) and to access the V1 use this url: v1.1.0

@stevenpkg
Copy link
Author

@germanattanasio will make the changes you requested. Also can we keep a V1 snapshot/version so anyone that want to look at V1 code can.

@Oliver-I
Copy link

@stevenpkg I have updated the readme file on your branch.

@germanattanasio we always test on the cloud using dev UIs to see how the system reacts within the cloud.

@germanattanasio
Copy link
Contributor

@stevenpkg All the releases are stored in the Releases tab https://github.com/watson-developer-cloud/assistant-intermediate/releases

This will be a major release so we will start with `2.0.0

@germanattanasio germanattanasio merged commit ff8760b into watson-developer-cloud:master Dec 10, 2018
@watson-github-bot
Copy link
Member

🎉 This PR is included in version 2.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

None yet

4 participants