fix: support disableSslVerification when user provides https agent
#1055
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when a user provides a custom https agent, we don't want to override the `disableSslVerification` behavior. this was happening before, but has been fixed in the core. this commit bumps the core version to include this fix
mediumTaj
approved these changes
Aug 6, 2020
apaparazzi0329
approved these changes
Aug 6, 2020
watson-github-bot
pushed a commit
that referenced
this pull request
Aug 6, 2020
## [5.6.2](v5.6.1...v5.6.2) (2020-08-06) ### Bug Fixes * support `disableSslVerification` when user provides https agent ([#1055](#1055)) ([4ab77e1](4ab77e1))
|
🎉 This PR is included in version 5.6.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the core version to include a bug fix. This bug caused
disableSslVerificationto be ignored when users provided a custom https agent (which they would do if using a proxy, for example).Code for the fix is here - IBM/node-sdk-core#104
This also fixes a bug that was preventing query parameters to be constructed properly.
Code for that is here - IBM/node-sdk-core#106