Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support for keywords, keywords_threshold, and word_alternatives_thres… #188

Merged
merged 4 commits into from
Dec 22, 2015

Conversation

monte-hayward
Copy link

The v1 service wrapper would pick params allowed to be sent to the service. This pr updates the "allowed" list with the new parameters announced in Updates for December 2015.

adds support for keywords, keywords_threshold, and word_alternatives_threshold

@monte-hayward
Copy link
Author

recognizeStream was untested before, and now has some tests.
Imo, it has more coverage than before the commit.
Maybe the Coveralls fail is due to coveralls@2.11.5 breaks build #176?
Thanks

@@ -394,8 +397,7 @@ function RecognizeStream(options){
'content-type': 'audio/wav', // todo: try to determine content-type from the file extension if available
'continuous': false,
'interim_results': true
}, pick(options, ['continuous', 'max_alternatives', 'timestamps',
'word_confidence', 'inactivity_timeout', 'content-type', 'interim_results']));
}, pick(options, [PARAMS_ALLOWED]));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this line should be

pick(options, PARAMS_ALLOWED));

@germanattanasio germanattanasio self-assigned this Dec 21, 2015
germanattanasio added a commit that referenced this pull request Dec 22, 2015
support for keywords, keywords_threshold, and word_alternatives_thres…
@germanattanasio germanattanasio merged commit 73245dd into watson-developer-cloud:dev Dec 22, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants