[discovery] Add sort parameter for Discovery query

[maniax89]

Description

Adds the sort parameter to the Discovery query method -> see https://watson-api-explorer.mybluemix.net/apis/discovery-v1#!/Queries/get_v1_environments_environment_id_collections_collection_id_query for details

Checklist

• npm test passes (tip: npm run autofix can correct most style issues)
• tests are included
• documentation is changed or added
• link to public docs when adding new a service or new features for an existing service

New version_date Checklist

• A new constant is avaliable with the version_date
• The new constant has a comment that summarizes the changes and/or links to relevant doc pages
• Any older version_date constants remain intact
• The error message thrown if the service is created without a version_date indicates the new version_date constant
• The example in the README includes the new version_date constant
• Any relevant code in the examples/ folder has been updated to use the new version_date constant
• Most tests are updated to the new version_date
• 1-2 new tests are added that use the old version_date (optional, but preferred) - (no behavior is changed before/after the version date change to show any sort of different results)

[CLAassistant]

All committers have signed the CLA.

[germanattanasio]

LGTM

[kognate]

Is sorting supported in the newest version and should the default version string change?

[maniax89]

so its available in the newest version, just not sure what to do about the version string. i.e. it will work with any version date string since it isn't changing an existing parameter behavior, but adding a new one

[kognate]

So if I pass the old version string it will still sort?

…

On Thu, Apr 27, 2017, 3:12 PM Andrew Turgeon ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In discovery/v1.js <#446 (comment)> : > * @param {Number} [params.offset=0] For pagination purposes. Returns additional pages of results. Deep pagination is highly unperformant, and should be avoided. + * @param {String} [params.return] A comma separated list of the portion of the document hierarchy to return. + * @param {String} [params.sort] A comma separated list of fields in the document to sort on. You can optionally specify a sort direction by prefixing the field with - for descending or + for ascending. Ascending is the default sort direction if no prefix is specified. so its available in the newest version, just not sure what to do about the version string. i.e. it will work with any version date string since it isn't changing an existing parameter behavior, but adding a new one — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#446 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAB8wkCC4AISdUXAX9V3_B44hlbqlpzsks5r0OiYgaJpZM4NKpH9> .

[maniax89]

correct

[maniax89]

At some point, version=2017-04-27 will do something on the query side when we do an api-breaking change. for now, it doesn't break existing behavior therefore the version date doesn't have any affect on the API call for this sort= parameter. But I can bump the default version to be consistent for how we would like it to work