fix: refresh iam tokens in websocket methods #913
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
germanattanasio
approved these changes
Jul 17, 2019
it has been removed
Codecov Report
@@ Coverage Diff @@
## master #913 +/- ##
=========================================
- Coverage 54.03% 52.7% -1.33%
=========================================
Files 18 18
Lines 4466 4614 +148
Branches 907 952 +45
=========================================
+ Hits 2413 2432 +19
- Misses 2051 2180 +129
Partials 2 2
Continue to review full report at Codecov.
|
watson-github-bot
pushed a commit
that referenced
this pull request
Jul 17, 2019
## [4.2.4](v4.2.3...v4.2.4) (2019-07-17) ### Bug Fixes * refresh iam tokens in websocket methods ([#913](#913)) ([5a2876a](5a2876a))
|
🎉 This PR is included in version 4.2.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It occurred to me the other day that, in the websocket methods, there is no need to wrap the token request logic in an "is authenticated" style boolean variable. If the same Stream class is closed and used to open another connection, the token could not be refreshed. Also, if the token is stored and not expired, there is no performance hit from the logic because the token manager will give back the stored token.
This is a small change but I felt like it was worth it to make.