Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: AuthorizationV1.Options requires type definitions for iam_apikey and ibm_url #917

Merged

Conversation

nhayashida
Copy link
Contributor

Though typing authorization/V1 were updated in #910, definitions for iam_apikey and ibm_url options are missing.
http://watson-developer-cloud.github.io/node-sdk/master/#authorization

Checklist
  • npm test passes (tip: npm run autofix can correct most style issues)
  • tests are included
  • documentation is changed or added
  • link to public docs when adding new a service or new features for an existing service

@CLAassistant
Copy link

CLAassistant commented Jul 18, 2019

CLA assistant check
All committers have signed the CLA.

@codecov-io
Copy link

codecov-io commented Jul 18, 2019

Codecov Report

Merging #917 into master will decrease coverage by 27.61%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #917       +/-   ##
===========================================
- Coverage   53.94%   26.33%   -27.62%     
===========================================
  Files          18       18               
  Lines        4462     4462               
  Branches      905      905               
===========================================
- Hits         2407     1175     -1232     
- Misses       2053     3286     +1233     
+ Partials        2        1        -1
Impacted Files Coverage Δ
lib/common.ts 30% <0%> (-70%) ⬇️
assistant/v2.ts 20.33% <0%> (-62.72%) ⬇️
test/resources/service_error_util.js 20% <0%> (-60%) ⬇️
lib/synthesize-stream.ts 25.86% <0%> (-56.9%) ⬇️
assistant/v1.ts 19.29% <0%> (-56.78%) ⬇️
lib/recognize-stream.ts 14.63% <0%> (-50.01%) ⬇️
text-to-speech/v1-generated.ts 42.17% <0%> (-36.6%) ⬇️
language-translator/v3.ts 30.56% <0%> (-29.26%) ⬇️
tone-analyzer/v3.ts 61.17% <0%> (-28.24%) ⬇️
personality-insights/v3.ts 63.04% <0%> (-27.18%) ⬇️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d0bd0a8...13ac681. Read the comment docs.

@germanattanasio germanattanasio merged commit b38d692 into watson-developer-cloud:master Jul 19, 2019
watson-github-bot pushed a commit that referenced this pull request Jul 19, 2019
## [4.2.5](v4.2.4...v4.2.5) (2019-07-19)

### Bug Fixes

* AuthorizationV1.Options requires type definitions for iam_a… ([#917](#917)) ([b38d692](b38d692))
* type definitions for iam_apikey and ibm_url ([13ac681](13ac681))
@watson-github-bot
Copy link
Member

🎉 This PR is included in version 4.2.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

dpopp07 pushed a commit that referenced this pull request Jul 19, 2019
fix: AuthorizationV1.Options requires type definitions for iam_apikey and ibm_url
(cherry picked from commit b38d692)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

None yet

5 participants