Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ignore unecessary files for npm releases #962

Merged
merged 1 commit into from
Sep 18, 2019
Merged

fix: ignore unecessary files for npm releases #962

merged 1 commit into from
Sep 18, 2019

Conversation

MasterOdin
Copy link
Contributor

Fixes #952

Adds npmignore rules for files that are not necessary for the NPM install to work, which should slim down the size of the npm install by ~926kb.

Checklist
  • npm test passes (tip: npm run autofix can correct most style issues)

@codecov-io
Copy link

codecov-io commented Sep 17, 2019 •
edited
Loading

Codecov Report

Merging #962 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #962   +/-   ##
=======================================
  Coverage   64.28%   64.28%           
=======================================
  Files           2        2           
  Lines          14       14           
  Branches        3        3           
=======================================
  Hits            9        9           
  Misses          4        4           
  Partials        1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3014478...e7bc17f. Read the comment docs.

dpopp07
dpopp07 approved these changes Sep 18, 2019
View reviewed changes
Copy link
Contributor

@dpopp07 dpopp07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks for doing this!

@dpopp07 dpopp07 merged commit 93eb677 into watson-developer-cloud:master Sep 18, 2019
@dpopp07
Copy link
Contributor

dpopp07 commented Sep 18, 2019

The builds have been failing on master so these aren't getting released. I'll get that sorted today

@MasterOdin
Copy link
Contributor Author

Yeah, looks like Travis all of a sudden stopped inserting a default install step in the builds I guess? Very strange.

@dpopp07
Copy link
Contributor

dpopp07 commented Sep 18, 2019

That's what I noticed too and actually added an explicit install step in this PR but there was still an issue with the Typedoc generator so I need to fix things there as well. Should hopefully have something up soon

@dpopp07
Copy link
Contributor

dpopp07 commented Sep 18, 2019

Turns out, there were some edits I made to the build for the release candidate branch that messed up some things in master. The releases should be going out shortly

watson-github-bot pushed a commit that referenced this pull request Sep 19, 2019
@semantic-release-bot
chore(release): 4.5.0 [skip ci]
e400240 
# [4.5.0](v4.4.0...v4.5.0) (2019-09-19)

### Bug Fixes

* ignore unecessary files for npm releases ([#962](#962)) ([93eb677](93eb677))

### Features

* separate strings out of primary SynthesizeStream pipe ([#957](#957)) ([3014478](3014478))
@watson-github-bot
Copy link
Member

🎉 This PR is included in version 4.5.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@MasterOdin MasterOdin deleted the npmignore branch September 27, 2019 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dpopp07 dpopp07 dpopp07 approved these changes

Assignees
No one assigned
Labels
released
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The npm package is very big and contains nearly 1MB of test output
4 participants
@MasterOdin @codecov-io @dpopp07 @watson-github-bot