Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discovery create_collection must send JSON #223

Merged
merged 1 commit into from
Jun 22, 2017

Conversation

bruceadams
Copy link
Contributor

@CLAassistant
Copy link

CLAassistant commented Jun 22, 2017

CLA assistant check
All committers have signed the CLA.

@codecov-io
Copy link

codecov-io commented Jun 22, 2017

Codecov Report

Merging #223 into master will decrease coverage by 2.82%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #223      +/-   ##
==========================================
- Coverage   84.31%   81.49%   -2.83%     
==========================================
  Files          24       24              
  Lines        1167     1167              
==========================================
- Hits          984      951      -33     
- Misses        183      216      +33
Impacted Files Coverage Δ
watson_developer_cloud/discovery_v1.py 100% <ø> (ø) ⬆️
watson_developer_cloud/language_translator_v2.py 44.82% <0%> (-31.04%) ⬇️
..._developer_cloud/watson_developer_cloud_service.py 63.54% <0%> (-9.38%) ⬇️
watson_developer_cloud/tone_analyzer_v3.py 92.3% <0%> (-7.7%) ⬇️
watson_developer_cloud/dialog_v1.py 38.88% <0%> (-5.56%) ⬇️
watson_developer_cloud/document_conversion_v1.py 93.75% <0%> (-3.13%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d250825...bff824a. Read the comment docs.

@jsstylos jsstylos merged commit 1d5802c into watson-developer-cloud:master Jun 22, 2017
@stevemar
Copy link

Since this is now merged, will this fix trigger a new release of the library?

@ltfschoen
Copy link

ltfschoen commented Jul 1, 2017

@stevemart I don't think it will automatically. I'm using Python 3.6.0 and watson-developer-cloud==0.26.0, but I just got the error WatsonException: Error: Unsupported Media Type, Code: 415 in my Jupyter Notebook, so I suspect this Pull Request that was merged 8 days ago isn't published yet on Python Package Index (PyPI) https://pypi.python.org/pypi/watson-developer-cloud?. It says my current version 0.26.0 was last updated to PyPI on 16 May 2017. I had to manually edit my file /Library/Frameworks/Python.framework/Versions/3.6/lib/python3.6/site-packages/watson_developer_cloud/discovery_v1.py with the file changes performed in this Pull Request and then restarted my Jupyter Notebook and the error went away.

@stevemar
Copy link

stevemar commented Jul 1, 2017

@ltfschoen perhaps "trigger" was the wrong word, I was trying to subtly ask the maintainers for a new release (0.27.0) :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants