Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): separate core functionalty out of watson sdk #58

Merged
merged 1 commit into from
Mar 28, 2019

Conversation

mamoonraja
Copy link
Member

@mamoonraja mamoonraja commented Mar 18, 2019

port core functionality from ibm_cloud_sdk_core

port core functionality from ibm_cloud_sdk_core
mediumTaj
mediumTaj previously approved these changes Mar 18, 2019
Copy link
Contributor

@mediumTaj mediumTaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 looks good!

@codecov-io
Copy link

codecov-io commented Mar 19, 2019

Codecov Report

Merging #58 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #58    +/-   ##
======================================
  Coverage     100%   100%            
======================================
  Files          20     16     -4     
  Lines        2603   2334   -269     
======================================
- Hits         2603   2334   -269
Impacted Files Coverage Δ
lib/ibm_watson/speech_to_text_v1.rb 100% <100%> (ø) ⬆️
lib/ibm_watson/assistant_v2.rb 100% <100%> (ø) ⬆️
lib/ibm_watson/discovery_v1.rb 100% <100%> (ø) ⬆️
...ib/ibm_watson/natural_language_understanding_v1.rb 100% <100%> (ø) ⬆️
lib/ibm_watson/text_to_speech_v1.rb 100% <100%> (ø) ⬆️
lib/ibm_watson/natural_language_classifier_v1.rb 100% <100%> (ø) ⬆️
lib/ibm_watson/language_translator_v3.rb 100% <100%> (ø) ⬆️
lib/ibm_watson/common.rb 100% <100%> (ø) ⬆️
lib/ibm_watson/personality_insights_v3.rb 100% <100%> (ø) ⬆️
lib/ibm_watson/tone_analyzer_v3.rb 100% <100%> (ø) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f317fdb...e0e5386. Read the comment docs.

@mamoonraja mamoonraja changed the base branch from master to v1.0.0 March 19, 2019 15:14
@mamoonraja mamoonraja mentioned this pull request Mar 19, 2019
7 tasks
@mamoonraja mamoonraja changed the base branch from v1.0.0 to master March 28, 2019 13:55
Copy link
Contributor

@mediumTaj mediumTaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 looks good!

@mamoonraja mamoonraja merged commit 3fa56d9 into master Mar 28, 2019
@watson-github-bot
Copy link
Member

🎉 This PR is included in version 0.14.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@germanattanasio germanattanasio deleted the separate-the-core branch March 29, 2019 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

None yet

4 participants