Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(stt): typo in recognize_websocket #70

Merged
merged 1 commit into from Jul 1, 2019
Merged

fix(stt): typo in recognize_websocket #70

merged 1 commit into from Jul 1, 2019

Conversation

mamoonraja
Copy link
Member

Fixes #69

@codecov-io
Copy link

Codecov Report

Merging #70 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #70   +/-   ##
=======================================
  Coverage   99.96%   99.96%           
=======================================
  Files          16       16           
  Lines        2652     2652           
=======================================
  Hits         2651     2651           
  Misses          1        1
Impacted Files Coverage Δ
lib/ibm_watson/speech_to_text_v1.rb 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bcf9101...d9cc846. Read the comment docs.

1 similar comment
@codecov-io
Copy link

codecov-io commented Jul 1, 2019 •
edited

Codecov Report

Merging #70 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #70   +/-   ##
=======================================
  Coverage   99.96%   99.96%           
=======================================
  Files          16       16           
  Lines        2652     2652           
=======================================
  Hits         2651     2651           
  Misses          1        1
Impacted Files Coverage Δ
lib/ibm_watson/speech_to_text_v1.rb 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bcf9101...d9cc846. Read the comment docs.

@mamoonraja mamoonraja requested a review from mediumTaj July 1, 2019 11:47
mediumTaj
mediumTaj approved these changes Jul 1, 2019
View reviewed changes
Copy link
Contributor

@mediumTaj mediumTaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 looks good!

@mamoonraja mamoonraja merged commit 3077a33 into master Jul 1, 2019
@watson-github-bot
Copy link
Member

🎉 This PR is included in version 0.18.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@mamoonraja mamoonraja deleted the fix/language_customization_id branch August 13, 2019 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mediumTaj mediumTaj mediumTaj approved these changes

Assignees
No one assigned
Labels
released
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"language_customization_id" does not work
4 participants
@mamoonraja @codecov-io @watson-github-bot @mediumTaj