Mdk/everything codable #910
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes all model definitions to be
Codable, replacing the previous scheme that usedEncodablefor models only used in requests andDecodablefor models only expected to be returned in responses.The original rationale for using either
EncodableorDecodablewas to avoid generating the encode or decode methods when they were not needed by the SDK. But we now rely on Swift to synthesize the encoding/decoding logic in most cases -- "additionalProperties" is an exception, but only affects a few classes.Making all the models "Codable" makes them more flexible and will allow features like pretty-printing (which needs the class to be "Encodable") to be implemented easily.