Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: create typings at pre-commit hook #97

Merged
merged 1 commit into from
Nov 21, 2022
Merged

chore: create typings at pre-commit hook #97

merged 1 commit into from
Nov 21, 2022

Conversation

gkampitakis
Copy link
Contributor

Hey 👋 thanks a lot for the work here 👏 . I have noticed from time to time issues with keeping typings up to date and I have seen the desire of automating them. This is not automation exactly but what it does runs a check on CI to create the typings. If there is git diff it means they are not up to date and it fails.

of course it will also fail if you probably do it by hand. I can add a "this is generated file" header. Tell me if this would help i can adjust it better.

@sibiraj-s
Copy link
Collaborator

Thank you for this. That is a pain definitely.

I can add a "this is generated file" header.

Yes. That would be better.

Also, rather than being in a lint step. It can be also generated and committed using the pre-commit step. We can use husky for this may be. Thoughts? For example see here

@gkampitakis
Copy link
Contributor Author

Yes, adding pre-commit sounds much better. Will update the pr 😄

@gkampitakis gkampitakis changed the title chore: add linting for typings chore: create typings at pre-commit hook Nov 20, 2022
@sibiraj-s
Copy link
Collaborator

@gkampitakis . Changes looks good. Please fix the CI.

@gkampitakis
Copy link
Contributor Author

I ran standard --fix and the tests look good. Thank you 😄

@sibiraj-s sibiraj-s merged commit f23ba4b into watson:master Nov 21, 2022
@sibiraj-s
Copy link
Collaborator

sibiraj-s commented Nov 21, 2022

Thanks @gkampitakis. Not making any release as this has no user impact.

@gkampitakis gkampitakis deleted the typings branch November 21, 2022 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants