Fix up geckodriver #44
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It doesn't support it and waiting thirty seconds for it to not obey the command is a waste of time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying out marionette for a project, I ran into some problems with geckodriver.
First off, it would just hang rather than exit. Tracked that down to a
sleep 1000.That cut the waiting down to 30 seconds. Apparently geckodriver doesn't support the shutdown command (mozilla/geckodriver#771 (comment)), so rather than waiting for it, skip directly to sending it signals.
And fix the build badge.
Doesn't solve all my problems though, seems that geckodriver spawns three other geckodriver processes when it's launched, which doesn't get killed when marionette closes it down, so I'm left with extra processes.
Experimenting a bit, I found out that killing the process group would take care of the extra geckodriver processes, but has the nasty sideeffect of also killing the Crystal process (as the geckodrivers are just added to its process group). Fixing that would involve making a special launcher for geckodriver that changes the process group before launching geckodriver, but that's a bit involved, so I can live with calling
killall geckodriverfor the time being.