Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix up geckodriver #44

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix up geckodriver #44

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
addaeaa
Only sleep for a second while waiting for shutdown
xendk Nov 22, 2023
48a6b4d
Don't send shutdown command to geckodriver
xendk Nov 22, 2023
97d9e0a
Fix badge
xendk Nov 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

**Looking for a co-maintainer for Marionette**. If interested just respond in the issue titled "Looking for a co-maintainer".

![GitHub Workflow Status](https://img.shields.io/github/workflow/status/watzon/marionette/specs?style=flat-square) ![License](https://img.shields.io/github/license/watzon/marionette?style=flat-square) ![Crystal Version](https://img.shields.io/badge/Crystal-1.0.0-%23333333?style=flat-square)
![GitHub Workflow Status](https://img.shields.io/github/actions/workflow/status/watzon/marionette/specs.yml?branch=master&style=flat-square) ![License](https://img.shields.io/github/license/watzon/marionette?style=flat-square) ![Crystal Version](https://img.shields.io/badge/Crystal-1.0.0-%23333333?style=flat-square)

<div align="center">
<img src="./assets/code.png">
Expand Down
8 changes: 6 additions & 2 deletions src/marionette/service.cr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ module Marionette
HTTP::Client.get(File.join(url.to_s, "shutdown"))
0.upto(30).each do
if open?
sleep 1000
sleep 1
else
break
end
Expand All @@ -84,7 +84,11 @@ module Marionette

def stop
if process = @process
send_remote_shutdown
# geckodriver does not support remote shutdown, so don't try
# and wait for it to close gracefully.
unless @browser.is_a?(Browser::Firefox)
send_remote_shutdown
end

begin
process.signal(Signal::INT)
Expand Down