go mods

[starkers]

I wanted to bosh on this a little but before I start I've updated it to go mods incase thats handy?

[JoelSpeed]

IIRC echo -e doesn't work on all platforms, are you working on linux or mac?

[starkers]

Ohh right, yes I recall something similar actually.. (I'm on linux)

If osx has an ancient bash maybe its echo -e won't work?

Can you test for me (assuming you're on osx?)
If it doesn't work, Try adding this to the Makefile: SHELL := /usr/bin/env bash (to ensure echo -e is calling the bash echo)

Otherwise I think we have some options:

1. drop colour prints, instead be clear using old school tricks like: =========== message =============
2. I can set the colours via tput
3. emojis? ¯_(ツ)_/¯

I'll give tput a quick test in meantime

[starkers]

according to stack overflow printf works on macOS

So I've updated it and it tests OK on linux (needed to add a \n to the end of each statement)

Can you test for me?

[JoelSpeed]

Looks good, will try to find a moment to test the printf later today

[JoelSpeed]

go mod download -x?

[starkers]

ohh right, I just tested and noticed that the Makefile's need some love so I'm working on them.. will take some testing but I hope to get generation +kustomize and as much as I can validated

[starkers]

Lots of updates done to the Makefiles to get everything working done

Stuck at go generate now as its attempting to pull content from the ../../vendor dep path.. I'll have to dig into this further to see how they're handling that in more recent versions of kube builder (I've not done much generating before)

[starkers]

Converting the PR to a draft as its WIP

[JoelSpeed]

That issue can be solved by creating a tools.go file that includes the tool dependency, eg following this https://marcofranssen.nl/manage-go-tools-via-go-modules

[github-actions]

This pull request has been inactive for 60 days. If the pull request is still relevant please comment to re-activate the pull request. If no action is taken within 7 days, the pull request will be marked closed.

[toelke]

Rebased to let the tests run.

I'll look at fixing the tests later or tomorrow.

[mamccorm]

Hey @toelke, I think I was able to repro the test failure locally. This seemed to fix it for me:

• Attempt to fix CI test failure, plus bump to go v1.21  starkers/wave#1

[Dentrax]

I've tried to combine this PR + Mark's but, but I couldn't able to compile the tests with: go test -c ./...:

# sigs.k8s.io/controller-runtime/pkg/log
../../../go/pkg/mod/sigs.k8s.io/controller-runtime@v0.2.2/pkg/log/log.go:48:31: cannot use NullLogger{} (value of type NullLogger) as logr.Logger value in argument to NewDelegatingLogger
../../../go/pkg/mod/sigs.k8s.io/controller-runtime@v0.2.2/pkg/log/null.go:30:21: cannot use NullLogger{} (value of type NullLogger) as logr.Logger value in variable declaration
../../../go/pkg/mod/sigs.k8s.io/controller-runtime@v0.2.2/pkg/log/null.go:48:37: undefined: logr.InfoLogger
../../../go/pkg/mod/sigs.k8s.io/controller-runtime@v0.2.2/pkg/log/null.go:54:9: cannot use log (variable of type NullLogger) as logr.Logger value in return statement
../../../go/pkg/mod/sigs.k8s.io/controller-runtime@v0.2.2/pkg/log/null.go:59:9: cannot use log (variable of type NullLogger) as logr.Logger value in return statement
../../../go/pkg/mod/sigs.k8s.io/controller-runtime@v0.2.2/pkg/log/deleg.go:103:9: cannot use res (variable of type *DelegatingLogger) as logr.Logger value in return statement
../../../go/pkg/mod/sigs.k8s.io/controller-runtime@v0.2.2/pkg/log/deleg.go:116:9: cannot use res (variable of type *DelegatingLogger) as logr.Logger value in return statement
# github.com/go-logr/glogr
../../../go/pkg/mod/github.com/go-logr/glogr@v0.1.0/glogr.go:18:9: cannot use glogger{…} (value of type glogger) as logr.Logger value in return statement
../../../go/pkg/mod/github.com/go-logr/glogr@v0.1.0/glogr.go:127:36: undefined: logr.InfoLogger
../../../go/pkg/mod/github.com/go-logr/glogr@v0.1.0/glogr.go:142:9: cannot use new (variable of type glogger) as logr.Logger value in return statement
../../../go/pkg/mod/github.com/go-logr/glogr@v0.1.0/glogr.go:148:9: cannot use new (variable of type glogger) as logr.Logger value in return statement
../../../go/pkg/mod/github.com/go-logr/glogr@v0.1.0/glogr.go:151:21: cannot use glogger{} (value of type glogger) as logr.Logger value in variable declaration
../../../go/pkg/mod/github.com/go-logr/glogr@v0.1.0/glogr.go:152:12: undefined: logr.InfoLogger
# github.com/go-logr/zapr
../../../go/pkg/mod/github.com/go-logr/zapr@v0.1.0/zapr.go:133:39: undefined: logr.InfoLogger
../../../go/pkg/mod/github.com/go-logr/zapr@v0.1.0/zapr.go:156:9: cannot use &zapLogger{…} (value of type *zapLogger) as logr.Logger value in return statement

[toelke]

I have merged #145. Thank you so much for the work in this PR!