Attempt to fix CI test failure, plus bump to go v1.21

[mamccorm]

Attempt to fix CI test failure:

/opt/hostedtoolcache/go/1.14.6/x64/bin/go generate ./pkg/... ./cmd/...
Error: stat ../../vendor/k8s.io/code-generator/cmd/deepcopy-gen/main.go: no such file or directory

Also bumped go to v1.21

[toelke]

I see the same error as wave-k8s#107 (comment) in my local tests.

I have created a branch in the main repo to run the workflow: https://github.com/wave-k8s/wave/actions/runs/8472508441/job/23214757845?pr=146 so that everyone has the same starting point.

Perhaps for debugging, you can create your own PR that combines your fixes on top of wave-k8s#107 for fast iteration? We can then clean up the mess when we are done…

Also, it turns out that docker build is not successful: https://github.com/wave-k8s/wave/actions/runs/8472508443/job/23214757843?pr=146

[mamccorm]

I think @Dentrax tried to to that here:

• go1.22 and k8s1.29 support wave-k8s/wave#145

[toelke]

At least the error in the test failure is different there.

[Dentrax]

Thanks for your comments, @toelke!

Yeah if we figure out the error I got there:

"error"="error updating instance default/example: no kind is registered for the type core.daemonset in scheme \"pkg/runtime/scheme.go:100\"" "controller"="daemonset-controller" "object"={"name"="example" "namespace"="default"} "namespace"="default" "name"="example"

I would be great so that we can move forward here. I spent another a few hours to fix that specific error, but no luck. I don't know if its a refactor issue or something is "really" wrong with testing strategies.

Do you see anything?

[toelke]

Well, If we could get the end2end tests working that would be a great first step. That means that docker build and basic functionality works.

The error you quote makes me think that there is some breaking change in some library since the version from 2016. That was why I hoped (in vain, it seems) that it would be possible to do the "dep -> go mod" without updating anything...

[Dentrax]

It would be possible to do the "dep -> go mod" without updating anything

I have also tried to do that but no luck. Do you have any thoughts/ideas/workarounds/hint about how to do that? There are some attempts on upstream repo but it seems nobody have any luck (Including me :D) here: https://github.com/wave-k8s/wave/pulls

[toelke]

I think that your current solutions are all pointing the right way. There appears to be some incompatibility with some remaining old code?

I unfortunately did not have an opportunity to really dig into the different error messages of your branch(es).

My course of action would be:

1. Try to get docker build to work and thus make the end2end-tests succeed.
2. Deal with the tests by "manually" running them without the Makefile, perhaps by excluding them one-by-one?
3. Fix the makefile regarding tests
4. Fix the makefile in regard to code-generation/release operations