Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix RBAC role examples to include DaemonSets and StatefulSets #56

Closed
wants to merge 4 commits into from
Closed

Fix RBAC role examples to include DaemonSets and StatefulSets #56

wants to merge 4 commits into from

Conversation

starkers
Copy link

  • manager RBAC expanded to include deployments and statefulsets
  • Dockerfile was referencing /bin/manager instead of /bin/wave

@JoelSpeed JoelSpeed changed the title Feature/misc Fix RBAC role examples to include DaemonSets and StatefulSets Aug 5, 2019
JoelSpeed
JoelSpeed approved these changes Aug 5, 2019
View reviewed changes
Copy link
Collaborator

@JoelSpeed JoelSpeed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@JoelSpeed
Copy link
Collaborator

/ok-to-test

@pusher-ci
Copy link

@starkers: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-wave-test-1.12 7af2446 link /test 1.12
pull-wave-verify-manifests 7af2446 link /test verify-manifests
pull-wave-test-1.13 7af2446 link /test 1.13

Full PR test history

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

JoelSpeed
JoelSpeed reviewed Aug 5, 2019
View reviewed changes
config/rbac/manager_role.yaml
@@ -8,6 +8,8 @@ rules:
- apps
resources:
- daemonsets
- deployments
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is autogenerated and has rules for deployments and statefulsets already, see lines #50 and #88

@JensErat JensErat mentioned this pull request Aug 25, 2019
Closed
@starkers starkers closed this Sep 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoelSpeed JoelSpeed JoelSpeed approved these changes

Assignees
No one assigned
Labels
ok-to-test size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@starkers @JoelSpeed @pusher-ci