Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add DaemonSet support #50

Merged
merged 2 commits into from
Apr 30, 2019
Merged

Add DaemonSet support #50

merged 2 commits into from
Apr 30, 2019

Conversation

JoelSpeed
Copy link
Collaborator

Fixes #21.

Adds DaemonSet support to the Wave controller. Mirrors the work done for StatefulSets.

Effectively a copy paste with lots of search and replacing for the terms StatefulSet -> DaemonSet and statefulset -> daemonset

@JoelSpeed JoelSpeed requested a review from a team April 30, 2019 14:58
mthssdrbrg
mthssdrbrg approved these changes Apr 30, 2019
View reviewed changes
Copy link
Contributor

@mthssdrbrg mthssdrbrg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had a quick scan, looks legit 👍

@JoelSpeed JoelSpeed merged commit 217c9b8 into master Apr 30, 2019
@pusher-ci pusher-ci deleted the deamonset-support branch April 30, 2019 16:20
@JoelSpeed JoelSpeed mentioned this pull request Aug 5, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mthssdrbrg mthssdrbrg mthssdrbrg approved these changes

Assignees
No one assigned
Labels
size/XL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support for Daemonsets
3 participants
@JoelSpeed @mthssdrbrg @pusher-ci