wip: use when directive for github release

release.Jenkinsfile

@@ -7,11 +7,11 @@ pipeline {
     }
 
     environment {
-      RELEASE_TYPE = 'release'
-      GIT_CREDENTIAL_ID = 'wf-jenkins-github'
-      GITHUB_TOKEN = credentials('GITHUB_TOKEN')
-      REPO_NAME = 'prometheus-storage-adapter'
-  }
+        RELEASE_TYPE = 'release'
+        GIT_CREDENTIAL_ID = 'wf-jenkins-github'
+        GITHUB_TOKEN = credentials('GITHUB_TOKEN')
+        REPO_NAME = 'prometheus-storage-adapter'
+    }
 
     parameters {
         string(name: 'VERSION_NUMBER', defaultValue: '', description: 'The version number to release as')
@@ -26,25 +26,25 @@ pipeline {
         stage('Build Linux Binary') {
             steps {
                 script {
-                    sh "make build-linux"
+                    sh 'make build-linux'
                 }
             }
         }
 
         stage('Create Github Release') {
+            when {
+                beforeAgent true
+                expression { return params.createGithubRelease }
+            }
             environment {
-              VERSION_NUMBER = "${params.VERSION_NUMBER}"
-              TARGET_COMITISH_TRIMMED = TARGET_COMITISH.minus("origin/")
-              RELEASE_NOTES = "${params.RELEASE_NOTES}"
-              IS_DRAFT = "${params.IS_DRAFT}"
-              IS_PRERELEASE = "${params.IS_PRERELEASE}"
+                VERSION_NUMBER = "${params.VERSION_NUMBER}"
+                TARGET_COMITISH_TRIMMED = TARGET_COMITISH.minus("origin/")
+                RELEASE_NOTES = "${params.RELEASE_NOTES}"
+                IS_DRAFT = "${params.IS_DRAFT}"
+                IS_PRERELEASE = "${params.IS_PRERELEASE}"
             }
             steps {
-                script {
-                    if (params.createGithubRelease) {
-                        sh 'curl -X POST -H \"Authorization: token ${GITHUB_TOKEN}\" -H \"Accept: application/vnd.github.v3+json\" https://api.github.com/repos/wavefrontHQ/${REPO_NAME}/releases -d \"{\\"tag_name\\": \\"${VERSION_NUMBER}\\", \\"target_commitish\\": \\"${TARGET_COMITISH_TRIMMED}\\", \\"name\\": \\"Release ${VERSION_NUMBER}\\", \\"body\\": \\"${RELEASE_NOTES}\\", \\"draft\\": ${IS_DRAFT}, \\"prerelease\\": ${IS_PRERELEASE}}\" '
-                    }
-                }
+                sh 'curl -X POST -H \"Authorization: token ${GITHUB_TOKEN}\" -H \"Accept: application/vnd.github.v3+json\" https://api.github.com/repos/wavefrontHQ/${REPO_NAME}/releases -d \"{\\"tag_name\\": \\"${VERSION_NUMBER}\\", \\"target_commitish\\": \\"${TARGET_COMITISH_TRIMMED}\\", \\"name\\": \\"Release ${VERSION_NUMBER}\\", \\"body\\": \\"${RELEASE_NOTES}\\", \\"draft\\": ${IS_DRAFT}, \\"prerelease\\": ${IS_PRERELEASE}}\" '
             }
         }
         /*
@@ -53,7 +53,6 @@ pipeline {
                 script {
                     docker.withRegistry('https://projects.registry.vmware.com', 'projects-registry-vmware-tanzu_observability-robot') {
                         def harborImage = docker.build("tanzu_observability/${REPO_NAME}:${VERSION_NUMBER}")
-                        // Push the container to the custom Registry
                         harborImage.push()
                         harborImage.push("latest")
                     }
@@ -68,7 +67,7 @@ pipeline {
         }
         */
     }
-    
+
     post {
       // Notify only on null->failure or success->failure or any->success
       /*