Dex 257 price and fee deviations #2036
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er-fee-settings-in-rest-api # Conflicts: # src/main/scala/com/wavesplatform/matcher/model/OrderValidator.scala
Merge remote-tracking branch 'remotes/origin/master' into DEX-257-price-and-fee-deviations # Conflicts: # src/main/scala/com/wavesplatform/matcher/error/MatcherError.scala # src/main/scala/com/wavesplatform/matcher/model/OrderValidator.scala # src/main/scala/com/wavesplatform/settings/fee/OrderFeeSettings.scala
…ce-and-fee-deviations # Conflicts: # src/main/scala/com/wavesplatform/matcher/model/OrderValidator.scala # src/main/scala/com/wavesplatform/settings/fee/OrderFeeSettings.scala
…ce-and-fee-deviations # Conflicts: # src/test/scala/com/wavesplatform/matcher/MatcherTestData.scala # src/test/scala/com/wavesplatform/matcher/model/OrderValidatorSpecification.scala
Codecov Report
@@ Coverage Diff @@
## master #2036 +/- ##
==========================================
+ Coverage 54.88% 54.97% +0.09%
==========================================
Files 367 369 +2
Lines 12350 12384 +34
Branches 714 720 +6
==========================================
+ Hits 6778 6808 +30
- Misses 5572 5576 +4
Continue to review full report at Codecov.
|
koloale
suggested changes
Mar 19, 2019
src/test/scala/com/wavesplatform/matcher/model/OrderValidatorSpecification.scala
Outdated
Show resolved
Hide resolved
src/main/scala/com/wavesplatform/matcher/model/OrderValidator.scala
Outdated
Show resolved
Hide resolved
koloale
approved these changes
Mar 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.