Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

any + should be ignored when parsing config file #125

Closed
jumps-are-op opened this issue May 22, 2022 · 3 comments · Fixed by #135
Closed

any + should be ignored when parsing config file #125

jumps-are-op opened this issue May 22, 2022 · 3 comments · Fixed by #135
Assignees
Labels
Enhancement New feature or request

Comments

@jumps-are-op
Copy link

Version Information:

  • Distribution Information Linux logic 5.17.8-arch1-1 #1 SMP PREEMPT Mon, 16 May 2022 20:45:27 +0000 x86_64 GNU/Linux
  • swhkd version swhkd 1.2.0

Describe the bug:
in sxhkd you can do

any + F9
    /path/to/bin

and it gonna be treated as

F9
    /path/to/bin

but swhkd doesn't do that

Expected behavior:
swhkd to ignore any + when parsing config file and to treat any + F9 as F9

Actual behavior:
swhkd print

[2022-05-22T20:00:05Z ERROR swhkd] Config Error: Error parsing config file "/etc/swhkd/swhkdrc". Unknown symbol at line 2.

then exit

To Reproduce:

  1. add any + to a hot key in your config file
  2. reload swhkd config

Additional information:
see man sxhkd to know other modifiers that sxhkd support instead of waiting people to report them one by one

@jumps-are-op jumps-are-op added the Bug Something isn't working label May 22, 2022
@Shinyzenith Shinyzenith added the Enhancement New feature or request label May 23, 2022
@Shinyzenith
Copy link
Member

Any modifier has not been implemented yet.. will consider binding it soon.

@Shinyzenith Shinyzenith removed the Bug Something isn't working label May 23, 2022
@Shinyzenith
Copy link
Member

see man sxhkd to know other modifiers that sxhkd support instead of waiting people to report them one by one

Feel free to open a PR. I cannot and will not expect someone here to bind them all for others. We bound what we needed and bind extra modifiers as and when requests come in. Initially we wanted to support it all but we all have lives outside of github so the interest died down.

@EdenQwQ EdenQwQ linked a pull request Jun 13, 2022 that will close this issue
@EdenQwQ
Copy link
Member

EdenQwQ commented Jun 13, 2022

@jumps-are-op Please check out pr#130

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request
5 participants