Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feature] config/daemon: added any modifier #130

Closed
wants to merge 2 commits into from
Closed

[feature] config/daemon: added any modifier #130

wants to merge 2 commits into from

Conversation

EdenQwQ
Copy link
Member

@EdenQwQ EdenQwQ commented Jun 13, 2022

any represent any available modifiers.

any + a
    1

is the same as

super + a
    1
ctrl + a
    1
shift + a
    1
alt + a
    1

but this is implemented by modifying the daemon part, not expanding the config.

@EdenQwQ EdenQwQ linked an issue Jun 13, 2022 that may be closed by this pull request
any + should be ignored when parsing config file #125
Closed
@EdenQwQ EdenQwQ mentioned this pull request Jun 13, 2022
Closed
@EdenQwQ EdenQwQ added the Enhancement New feature or request label Jun 13, 2022
Shinyzenith
Shinyzenith approved these changes Jun 14, 2022
View reviewed changes
Copy link
Member

@Shinyzenith Shinyzenith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Shinyzenith
Copy link
Member

Shinyzenith commented Jun 14, 2022 •
edited
Loading

I'll merge when I get home or you can merge it yourself.

Actually on second thoughts, lets wait till we finish documentation.

@Shinyzenith Shinyzenith deleted the implement_any_modifier branch June 25, 2022 03:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shinyzenith Shinyzenith Shinyzenith approved these changes

@angelofallars angelofallars Awaiting requested review from angelofallars

Assignees
No one assigned
Labels
Enhancement New feature or request
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

any + should be ignored when parsing config file
2 participants
@EdenQwQ @Shinyzenith