Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This is a PR that has merged all the other recent PRs. #135

Merged
merged 10 commits into from
Jun 24, 2022

Conversation

EdenQwQ
Copy link
Member

@EdenQwQ EdenQwQ commented Jun 15, 2022

No description provided.

@EdenQwQ EdenQwQ requested a review from Shinyzenith June 15, 2022 06:03
@Shinyzenith
Copy link
Member

I've already approved all of these prs in the previous ones 😄. Waiting on Angelo now.
If they don't get time, I'll merge it.

@Shinyzenith Shinyzenith added Documentation Improvements or additions to documentation Enhancement New feature or request labels Jun 16, 2022
@Shinyzenith
Copy link
Member

Shinyzenith commented Jun 16, 2022

Apologies, I just remembered I left the following commit on the device argument pr:

Path can change often, maybe a name based identifier would help too?

This is the model I had in mind:
swhkd chooses the keyboards based on it's current algorithm then people can add more devices using --add-device flag or disable select devices with some other flag such as --ignore-device

This will be less tedious than hardcoding all device paths every single time.

@EdenQwQ
Copy link
Member Author

EdenQwQ commented Jun 19, 2022

Apologies, I just remembered I left the following commit on the device argument pr:

Path can change often, maybe a name based identifier would help too?

This is the model I had in mind: swhkd chooses the keyboards based on it's current algorithm then people can add more devices using --add-device flag or disable select devices with some other flag such as --ignore-device

This will be less tedious than hardcoding all device paths every single time.

I'll try to implement the name based identifier. But choosing devices by --device seems more straight forward and easier to implement for me.

@Shinyzenith
Copy link
Member

I'll try to implement the name based identifier. But choosing devices by --device seems more straight forward and easier to implement for me.

Understandable, I will chime in on it asap.

@Shinyzenith Shinyzenith merged commit e7a3cce into main Jun 24, 2022
@Shinyzenith Shinyzenith deleted the keymodes_devel branch June 25, 2022 03:51
This was referenced Jun 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Improvements or additions to documentation Enhancement New feature or request
2 participants