Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various display rotation / portrait orientation issues #1537

Closed
waydabber opened this issue Feb 16, 2023 · 2 comments
Closed

Various display rotation / portrait orientation issues #1537

waydabber opened this issue Feb 16, 2023 · 2 comments
Assignees
Labels
bug Something isn't working done All tasks are completed released Released
Milestone

Comments

@waydabber
Copy link
Owner

For more info see:

https://ptb.discord.com/channels/903276571773771796/903276571773771799/1075885910119436288

  • The native resolution is marked as Invalid in Ventura 13.2 but just happens to work. The app checks if it's Ventura 13.2 or newer and does match the native resolution and un-invalidate it in a special logic. But the app doesn't account for the fact that the resolution might be flipped so it's not un-invalidated then. This should be fixed.
@waydabber waydabber added the bug Something isn't working label Feb 16, 2023
@waydabber
Copy link
Owner Author

Also this needs investigating: https://ptb.discord.com/channels/903276571773771796/903276571773771799/1076124137950552104


Abt #1537, there is a problem with screen rotation in BetterDisplay.

If the screen resolution is set to anything other than 100%, rotating the screen will cause the screen size jumping.

For example, with the screen set to 120% display (2304x1296 HiDPI) in the horizontal position (no rotation), rotate the screen 90° in BetterDisplay to portrait view. The screen resolution will then change to 200% (2160x3840 HiDPI).

In this state, change the screen resolution to 120% (1296x2304 HiDPI) and change the rotation to the horizontal position. The screen size will then change to 68% (1296x729 HiDPI).

I think you may be confused about the handling of vertical and horizontal when the screen is rotated. Because when the resolution is set to 100%, this strange phenomenon does not occur.

BetterDisplay 1.4.3
MacBook Pro 13 inch M1 2020
macOS Monterey 12.6.3
Acer CB241HYK (23.8 inch 4K)
change rotation at 120%

@waydabber waydabber changed the title Some invalid resolutions do not show up properly when the display is in portrait orientation Various display rotation / portrait orientation issues Feb 17, 2023
@waydabber
Copy link
Owner Author

All right, the problem seems to be on the macOS side - these resolutions (having flags that do not correspond to any specified display mode flags) do not honor rotation settings. I'll try to fix it with a workaround.

@waydabber waydabber self-assigned this Feb 21, 2023
@waydabber waydabber added in progress Implementing unreleased Not released yet in beta form labels Feb 21, 2023
@waydabber waydabber added this to the v1.4.4 milestone Feb 21, 2023
@waydabber waydabber added done All tasks are completed and removed in progress Implementing labels Feb 21, 2023
@waydabber waydabber added pre-release available Released as beta version and removed unreleased Not released yet in beta form labels Mar 2, 2023
@waydabber waydabber added released Released and removed pre-release available Released as beta version labels Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working done All tasks are completed released Released
Projects
None yet
Development

No branches or pull requests

1 participant