Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add color inversion to color table adjustments (that is compatible with software dimming) + CLI #2006

Closed
axelvugts opened this issue Jul 19, 2023 · 8 comments
Assignees
Labels
done All tasks are completed enhancement New feature or request released Released
Milestone

Comments

@axelvugts
Copy link

I've been using this great tool for a while now on my MBP (late 2016, 15", Monterey) and the brightness control worked like a charm! However, I recently upgraded to a 16" MBP (2022, Ventura) and now the software dimming feature no longer works as expected.

When software dimming is engaged, a white layer is projected over the screen, instead of a dark one. The lower the brightness setting, the more white the screen gets. This is probably caused by the Inverted Colours feature in macOS that I use. When I disable inverted colours, software dimming works as expected.
The weird thing is that software dimming worked just fine in combination with inverted colours on my Intel Mac running Monterey.

So, would it be possible to also invert the "dimming layer" colour, when inverted colours is enabled?

@waydabber waydabber added the enhancement New feature or request label Jul 19, 2023
@waydabber
Copy link
Owner

Indeed, with Apple Silicon, inversion seems to affect the color table (the app by default does not use a dimming layer). Until this is improved, you can use Color Adjustments to somewhat further dim the display.

@axelvugts
Copy link
Author

It's a shame really, I was hoping to benefit from the extra XDR brightness of the built-in display but the same problem happens there as well. So the only option for now is full XDR brightness or "standard" non-XDR brightness for now :)

@waydabber
Copy link
Owner

Right. I plan fix this in an upcoming version or if not possible then add an inversion filter to Color Adjustments.

@waydabber waydabber changed the title [Accessibility] Software dimming + inverted colours does not work Software dimming + inverted colors for Apple Silicon Jul 19, 2023
@waydabber waydabber changed the title Software dimming + inverted colors for Apple Silicon Add color inversion to color table adjustments (that is compatible with software dimming) Mar 22, 2024
@waydabber waydabber added this to the v2.3.0 milestone Mar 22, 2024
@waydabber waydabber self-assigned this Mar 22, 2024
@waydabber waydabber added in progress Implementing unreleased Not released yet in beta form labels Mar 22, 2024
@waydabber
Copy link
Owner

waydabber commented Mar 22, 2024

Framebuffer inversion (#2745) cannot properly support software (and Apple hardware) dimming it seems so I need to add inversion as an option to color controls.

(note: system accessibility invert uses the framebuffer method).

@waydabber
Copy link
Owner

Screenshot 2024-03-22 at 23 05 06

@waydabber waydabber added done All tasks are completed and removed in progress Implementing labels Mar 22, 2024
@axelvugts
Copy link
Author

That's awesome! Does this mean that I can keep using the built-in (Smart) Inverted Colours feature while this mode is enabled? Smart inverted colours comes with some cool freebies such as un-inverted images in Safari :)

@waydabber
Copy link
Owner

No, sadly this invert is a separate implementation from smart invert, will simply invert everything.

@waydabber waydabber changed the title Add color inversion to color table adjustments (that is compatible with software dimming) Add color inversion to color table adjustments (that is compatible with software dimming) + CLI Mar 23, 2024
@waydabber
Copy link
Owner

waydabber commented Mar 23, 2024

CLI examples:

betterdisplaycli toggle -inverted
betterdisplaycli set -namelike=MyDisplay -inverted=on
betterdisplaycli get -namelike=MyDisplay1,MyDisplay2 -inverted

@waydabber waydabber added released Released and removed unreleased Not released yet in beta form labels Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
done All tasks are completed enhancement New feature or request released Released
Projects
None yet
Development

No branches or pull requests

2 participants