Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Grayscale and Inverted framebuffer configurations to Image Adjustments + CLI #2745

Closed
autolyticus opened this issue Mar 11, 2024 · 6 comments
Assignees
Labels
done All tasks are completed enhancement New feature or request released Released
Milestone

Comments

@autolyticus
Copy link

I'm not sure if you consider that this falls within the purview of BetterDisplay or not, but I believe it would be a useful feature for BetterDisplay to allow controlling the "Color Filters" feature in Accessibility.

As a dev, I would love the ability to script toggle and untoggle grayscale to serve as a subtle reminder for me to remind myself to take a break. (Right now I'm using the native Shortcuts app for this)

As a user, I expected to find it under System Colors > Color Filters

Ref: As mentioned on the Discord :)

@waydabber waydabber added the enhancement New feature or request label Mar 11, 2024
@waydabber
Copy link
Owner

https://discord.com/channels/903276571773771796/903276571773771799/1215723957110706250

Sure. I can add color remap to grayscale (and invert) feature (will implement it for Apple Silicon).

@waydabber waydabber added in progress Implementing unreleased Not released yet in beta form labels Mar 11, 2024
@waydabber waydabber self-assigned this Mar 11, 2024
@waydabber waydabber added this to the TBD milestone Mar 11, 2024
@waydabber waydabber changed the title (Enhancement) Allow controlling the "Color Filters" feature in Accessibility Add system level Grayscale and Inverted screen configurations to Image Adjustments Mar 11, 2024
@waydabber
Copy link
Owner

Since these modify the framebuffer color mapping at a low level, you'll need to hold the OPTION button while opening Image Adjustments to reach these features. Reading the current value does not work well on external displays so this will be a simple clickable four-state setting (four optionally appearing menu items).

Screenshot 2024-03-11 at 20 55 47

@waydabber
Copy link
Owner

The associated CLI is a command so you need to use perform

Set all displays to grayscale, inverted, both, normal:

betterdisplaycli perform -grayscale
betterdisplaycli perform -inverted 
betterdisplaycli perform -invertedgrayscale
betterdisplaycli perform -normal  

Set a specific display only:

betterdisplaycli perform -namelike=MyDisplay -grayscale

@waydabber waydabber added done All tasks are completed and removed in progress Implementing labels Mar 11, 2024
@waydabber waydabber changed the title Add system level Grayscale and Inverted screen configurations to Image Adjustments Add system level Grayscale and Inverted screen configurations to Image Adjustments + CLI Mar 11, 2024
@waydabber
Copy link
Owner

waydabber commented Mar 12, 2024

I renamed the CLI parameters to these:

standardFramebuffer
invertedFramebuffer
grayscaleFramebuffer
invertedGrayscaleFramebuffer

@waydabber waydabber changed the title Add system level Grayscale and Inverted screen configurations to Image Adjustments + CLI Add Grayscale and Inverted framebuffer configurations to Image Adjustments + CLI Mar 12, 2024
@waydabber waydabber modified the milestones: TBD, v2.3.0 Mar 19, 2024
@waydabber waydabber added released Released and removed unreleased Not released yet in beta form labels Apr 8, 2024
@autolyticus
Copy link
Author

This is perfect for using on my eink display. I don't need to have a dark and light theme and I can just set my display to be inverted.

This is great! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
done All tasks are completed enhancement New feature or request released Released
Projects
None yet
Development

No branches or pull requests

2 participants